Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

also post on empty plan #1616

Merged
merged 1 commit into from
Jul 12, 2024
Merged

also post on empty plan #1616

merged 1 commit into from
Jul 12, 2024

Conversation

motatoes
Copy link
Contributor

@motatoes motatoes commented Jul 12, 2024

fixes #1557

We were not properly detecting empty plans when only outputs have changed

Also a refactor to use tfjson.Plan type from library instead of our custom types

Tested the fix here: diggerhq/test-tfvar-env#4

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@motatoes motatoes merged commit 61d7552 into develop Jul 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

changes to outputs that do not affect real resources/infra are not displayed in PR comment
2 participants