Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: move disable-locking flag to digger.yml #1577

Closed
motatoes opened this issue Jun 13, 2024 · 1 comment
Closed

Proposal: move disable-locking flag to digger.yml #1577

motatoes opened this issue Jun 13, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@motatoes
Copy link
Contributor

Currently we have disable locking in action.yml and it was working fine for both backendless and orchestrator modes.

However we recently moved orchestrator locking to be in database for performance reasons (#1524) .

Now we have introduced another issue because there is no longer a way to disable locking if you are using digger with orchestrator mode (the flag was only avaiable in cli and since with orchestrator locking no longer performed in the cli it means that you can no longer disable locking by passing disable-locking to the action directly.

Propose to move that flag to a top level digger.yml value since then both orchestrator and cli can read it unified and have consistent behaviour:

# digger.yml

disable_locking: true

projects:
    - name: balbla
      dir: bla

Then the backend can pick this up in the webhook and if set then we don't perform any locking checks. Also we deprecate the older disable-locking from the action and rely on digger.yml to perform this locking disabling moving forward

@motatoes motatoes added the good first issue Good for newcomers label Jun 13, 2024
@UtpalJayNadiger UtpalJayNadiger changed the title Propsal: move disable-locking flag to digger.yml Proposal: move disable-locking flag to digger.yml Jun 24, 2024
@motatoes
Copy link
Contributor Author

This is now done using a flag called pr_locks: false instead of disable_locking: true

https://docs.digger.dev/howto/disable-locking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant