Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: support single comment summary with orchestrator mode #1850

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
Prev Previous commit
Next Next commit
switch to lazy reporter
  • Loading branch information
motatoes committed Dec 21, 2024
commit 44c1aff697ac56ac447ff5f47d1b4e5cb0704e2b
1 change: 1 addition & 0 deletions backend/controllers/github.go
Original file line number Diff line number Diff line change
@@ -419,6 +419,7 @@ func handlePullRequestEvent(gh utils.GithubClientProvider, payload *github.PullR
return fmt.Errorf("error processing event")
}
}

diggerCommand, err := orchestrator_scheduler.GetCommandFromJob(jobsForImpactedProjects[0])
if err != nil {
log.Printf("could not determine digger command from job: %v", jobsForImpactedProjects[0].Commands)
5 changes: 2 additions & 3 deletions backend/services/spec.go
Original file line number Diff line number Diff line change
@@ -116,9 +116,8 @@ func GetSpecFromJob(job models.DiggerJob) (*spec.Spec, error) {
CommentId: strconv.FormatInt(*batch.CommentId, 10),
Job: jobSpec,
Reporter: spec.ReporterSpec{
//ReportingStrategy: "comments_per_run",
ReportingStrategy: "always_same_comment",
ReporterType: "lazy",
ReportingStrategy: "comments_per_run",
ReporterType: "basic",
ReportCommentId: job.Batch.PlaceholderCommentIdForReport,
},
Lock: spec.LockSpec{
9 changes: 0 additions & 9 deletions libs/spec/providers.go
Original file line number Diff line number Diff line change
@@ -133,15 +133,6 @@ func (r ReporterProvider) GetReporter(title string, reporterSpec ReporterSpec, c
IsSupportMarkdown: true,
ReportStrategy: strategy,
}, nil
case "lazy":
strategy := getStrategy(reporterSpec.ReportingStrategy)
ciReporter := reporting.CiReporter{
CiService: ciService,
PrNumber: prNumber,
IsSupportMarkdown: true,
ReportStrategy: strategy,
}
return ciReporter, nil
default:
return reporting.NoopReporter{}, nil
}
Loading
Oops, something went wrong.