Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always set right provider in ee #1868

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

motatoes
Copy link
Contributor

@motatoes motatoes commented Jan 8, 2025

always fetch teams list from DIGGER_GITHUB_HOSTNAME env variable if set

Summary by CodeRabbit

  • New Features
    • Enhanced VCS provider support to handle GitHub organization services
    • Added GitHub-specific token retrieval and service initialization for organization-level operations

Copy link
Contributor

coderabbitai bot commented Jan 8, 2025

Walkthrough

The changes extend the GetOrgService method in the VCSProviderAdvanced struct to support GitHub as a version control system (VCS) type. Previously, the method only explicitly handled GitLab and defaulted to a basic implementation for other VCS types. The new implementation for GitHub follows a similar pattern to the existing pull request service logic, retrieving GitHub authentication tokens from environment variables and creating a GitHub-specific organization service.

Changes

File Change Summary
ee/cli/pkg/vcs/providers.go Added GitHub-specific handling in GetOrgService method, retrieving GitHub token and creating GitHub organization service

Poem

🐰 A rabbit's tale of code so bright,
GitHub now joins the VCS fight!
With tokens checked and services new,
Our provider leaps with vigor true 🚀
Expanding reach, one method at a time! 🌟


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d6e8d26 and ee973cf.

📒 Files selected for processing (1)
  • ee/cli/pkg/vcs/providers.go (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Build
  • GitHub Check: Build
🔇 Additional comments (2)
ee/cli/pkg/vcs/providers.go (2)

40-45: LGTM! The GitHub support implementation looks good.

The implementation follows the same pattern as the existing GitHub case in GetPrService, maintaining consistency in the codebase.


40-45: 🛠️ Refactor suggestion

Consider adding support for custom GitHub hostname.

Based on the PR objectives, the code should use DIGGER_GITHUB_HOSTNAME environment variable when set, similar to how GitLab uses DIGGER_GITLAB_BASE_URL.

Here's how you could modify the code:

 case "github":
   token := os.Getenv("GITHUB_TOKEN")
   if token == "" {
     return nil, fmt.Errorf("failed to get github service: GITHUB_TOKEN not specified")
   }
-  return github2.GithubServiceProviderAdvanced{}.NewService(token, vcsSpec.RepoName, vcsSpec.RepoOwner)
+  hostname := os.Getenv("DIGGER_GITHUB_HOSTNAME")
+  return github2.GithubServiceProviderAdvanced{}.NewServiceWithHost(token, vcsSpec.RepoName, vcsSpec.RepoOwner, hostname)

Note: This assumes that GithubServiceProviderAdvanced has or will have a NewServiceWithHost method to handle custom GitHub Enterprise hostnames.

Let's verify if the NewServiceWithHost method exists:


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@motatoes motatoes changed the title always fix right provider in ee always set right provider in ee Jan 8, 2025
@motatoes motatoes merged commit de0a222 into develop Jan 8, 2025
11 checks passed
@motatoes motatoes deleted the fix/fetch-right-provider-in-ee branch January 8, 2025 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant