Pro deployment initial #1883
Pro deployment initial #1883
Conversation
WalkthroughThis pull request introduces a new GitHub Actions workflow to automate deployment of the pro-backend application on pushes to the develop and pro branches. Additionally, the Dockerfile_backend is updated with an upgraded ATLAS_VERSION, and a new fly-pro.toml configuration file is added for the digger-pro application. The configuration file defines essential environment variables, service ports, concurrency settings, and virtual machine details for deployment. Changes
Sequence Diagram(s)sequenceDiagram
participant Dev as Developer
participant GH as GitHub Actions
participant Repo as Repository
participant Fly as Fly.io
Dev->>Repo: Push code to develop/pro branch
Repo->>GH: Trigger pro-deploy workflow
GH->>GH: Run "deploy" job steps
GH->>Repo: Checkout code (actions/checkout)
GH->>GH: Setup flyctl CLI (superfly/flyctl-actions)
GH->>Fly: Execute deploy command with fly-pro.toml
Fly-->>GH: Deployment outcome
GH-->>Dev: Notify success/failure
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR sets up the initial deployment infrastructure for the pro backend service using Fly.io, including deployment workflows and container configurations.
- New GitHub Action
.github/workflows/pro-deploy.ymlautomates deployments to Fly.io for 'develop' and 'pro' branches - Added
fly-pro.tomlconfigures production environment with 1GB memory, JWT auth, and HTTPS enforcement - Warning:
Dockerfileuses invalid Go version "1" and lacks necessary runtime dependencies - Updated Atlas migration tool to v0.31.0 in
Dockerfile_backendwith Ubuntu 24.04 base image - Service configured with connection-based concurrency limits (20 soft, 25 hard) in
fly-pro.toml
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
4 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
| - develop | ||
| - pro |
There was a problem hiding this comment.
logic: Deploying on both 'develop' and 'pro' branches could lead to unintended deployments. Consider limiting to just 'pro' branch for production deployments.
| deploy: | ||
| name: Deploy app | ||
| runs-on: ubuntu-latest | ||
| concurrency: deploy-group # optional: ensure only one action runs at a time |
There was a problem hiding this comment.
style: Consider using a more specific concurrency group name like 'pro-deploy-group' to avoid conflicts with other workflows
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)
.github/workflows/pro-deploy.yml (1)
7-8:⚠️ Potential issueBranch Trigger Caution: Limit Deployments to Production Only
The workflow is triggered for both thedevelopandprobranches. Deploying on thedevelopbranch might lead to unintended deployments in a production context. If this behavior is not desired, please consider removing thedevelopbranch from the trigger.- - develop - - pro + - pro
🧹 Nitpick comments (1)
.github/workflows/pro-deploy.yml (1)
16-16: Pin Workflow Action Version for Stability
Using themasterbranch for thesuperfly/flyctl-actions/setup-flyctlaction might lead to unexpected changes when that branch is updated. To ensure consistent and predictable deployments, pin this action to a specific version tag.- - uses: superfly/flyctl-actions/setup-flyctl@master + - uses: superfly/flyctl-actions/setup-flyctl@vX.Y.Z # Replace vX.Y.Z with the desired version
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/pro-deploy.yml(1 hunks)Dockerfile_backend(1 hunks)fly-pro.toml(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- Dockerfile_backend
- fly-pro.toml
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Build
- GitHub Check: Build
- GitHub Check: Build
🔇 Additional comments (1)
.github/workflows/pro-deploy.yml (1)
13-13: Enhance Concurrency Group Naming for Clarity
The current concurrency group is nameddeploy-group. For improved clarity and to avoid conflicts with other workflows, consider renaming it to a more specific name likepro-deploy-group.- concurrency: deploy-group # optional: ensure only one action runs at a time + concurrency: pro-deploy-group # optional: ensure only one action runs at a time
also updated atlas version to v0.31.0 in dockerfile to get the deployment working
Summary by CodeRabbit
New Features
Chore