introduce support for custom build outputs #10642
Closed
+74
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## v2 #10642 +/- ##
==========================================
- Coverage 59.07% 50.88% -8.20%
==========================================
Files 107 107
Lines 9469 9494 +25
==========================================
- Hits 5594 4831 -763
- Misses 3291 4125 +834
+ Partials 584 538 -46
☔ View full report in Codecov by Sentry. |
|
What was the reason this was closed? I use build outputs to take unit tests results and report them back to CI. Without this support, looks like I cannot use compose in CI for build/test. I like the proposal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
introduce
--outputflag onbuildcommand to export built artifact with alternate exporter.AFAICT having this as part of the compose.yaml service definition doesn't make much sense as
compose upscenario require image to be exported to container runtime local store. On the other hand, maybe there's room for new use-cases?Related issue
fixes #9586
(not mandatory) A picture of a cute animal, if possible in relation to what you did