Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config/secret handling: Copy files into containers instead of bind mounting #12448

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
minor code format fix
Signed-off-by: schaubl <schaubl@users.noreply.github.com>
  • Loading branch information
schaubl committed Feb 18, 2025
commit 0762b9417dd1be20cd55bd00975fb979094c2753
1 change: 0 additions & 1 deletion pkg/compose/create.go
Original file line number Diff line number Diff line change
@@ -976,7 +976,6 @@ func checkContainerConfigsSecrets(p types.Project, s types.ServiceConfig) error
}

func checkContainerConfigs(p types.Project, s types.ServiceConfig) error {

for _, config := range s.Configs {
definedConfig := p.Configs[config.Source]
if definedConfig.External {
2 changes: 1 addition & 1 deletion pkg/compose/secrets.go
Original file line number Diff line number Diff line change
@@ -51,7 +51,7 @@ func (s *composeService) injectSecrets(ctx context.Context, project *types.Proje
if content == "" {
continue
}

if config.Target == "" {
config.Target = "/run/secrets/" + config.Source
} else if !isAbsTarget(config.Target) {