Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config/secret handling: Copy files into containers instead of bind mounting #12448

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+63 −98
Open

Update config/secret handling: Copy files into containers instead of bind mounting #12448

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d9e531d
Do not bind mount configs and secrets when source is a file but copy …
schaubl Jan 9, 2025
b530e6c
Remove warning about unsupported "uid", "gid" and "mode" for configs …
schaubl Feb 18, 2025
66579df
Merge branch 'main' into fix-configs-secrets-2
schaubl Feb 18, 2025
c835bbc
configs and secrets: move the check of read-only service before conta…
schaubl Feb 18, 2025
0762b94
minor code format fix
schaubl Feb 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove warning about unsupported "uid", "gid" and "mode" for configs … 
…and secrets

Signed-off-by: schaubl <schaubl@users.noreply.github.com>
  • Loading branch information
@schaubl
schaubl committed Feb 18, 2025
commit b530e6c0bbb4a1d6e8259612d641e1f3a49e6f64
8 changes: 0 additions & 8 deletions pkg/compose/create.go
View file
Original file line number Diff line number Diff line change
@@ -994,10 +994,6 @@ func checkContainerConfigs(p types.Project, s types.ServiceConfig) error {
continue
}

if config.UID != "" || config.GID != "" || config.Mode != nil {
logrus.Warn("config `uid`, `gid` and `mode` are not supported, they will be ignored")
}

if _, err := os.Stat(definedConfig.File); os.IsNotExist(err) {
logrus.Warnf("config file %s does not exist", definedConfig.Name)
}
@@ -1024,10 +1020,6 @@ func checkContainerSecrets(p types.Project, s types.ServiceConfig) error {
continue
}

if secret.UID != "" || secret.GID != "" || secret.Mode != nil {
logrus.Warn("secrets `uid`, `gid` and `mode` are not supported, they will be ignored")
}

if _, err := os.Stat(definedSecret.File); os.IsNotExist(err) {
logrus.Warnf("secret file %s does not exist", definedSecret.Name)
}