configs and secrets: move the check of read-only service before conta…

…iner creation

Signed-off-by: schaubl <schaubl@users.noreply.github.com>

pkg/compose/create.go

@@ -990,6 +990,10 @@ func checkContainerConfigs(p types.Project, s types.ServiceConfig) error {
 			return errors.New("Docker Compose does not support configs.*.template_driver")
 		}
 
+		if s.ReadOnly {
+			return fmt.Errorf("cannot create config %q in read-only service %q", definedConfig.Name, s.Name)
+		}
+
 		if definedConfig.Environment != "" || definedConfig.Content != "" {
 			continue
 		}
@@ -1016,6 +1020,10 @@ func checkContainerSecrets(p types.Project, s types.ServiceConfig) error {
 			return errors.New("Docker Compose does not support secrets.*.template_driver")
 		}
 
+		if s.ReadOnly {
+			return fmt.Errorf("cannot create secret %q in read-only service %q", definedSecret.Name, s.Name)
+		}
+
 		if definedSecret.Environment != "" {
 			continue
 		}

pkg/compose/secrets.go

@@ -51,10 +51,6 @@ func (s *composeService) injectSecrets(ctx context.Context, project *types.Proje
 		if content == "" {
 			continue
 		}
-
-		if service.ReadOnly {
-			return fmt.Errorf("cannot create secret %q in read-only service %s", file.Name, service.Name)
-		}
 
 		if config.Target == "" {
 			config.Target = "/run/secrets/" + config.Source
@@ -100,10 +96,6 @@ func (s *composeService) injectConfigs(ctx context.Context, project *types.Proje
 			continue
 		}
 
-		if service.ReadOnly {
-			return fmt.Errorf("cannot create config %q in read-only service %s", file.Name, service.Name)
-		}
-
 		if config.Target == "" {
 			config.Target = "/" + config.Source
 		}