-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduced include
to filter files considered by watch
#12584
Conversation
it would be nicer |
f127e03
to
60038fb
Compare
cc @jhrotko |
@ndeloof so in this case can |
@jhrotko no it can't - this is intentional at this stage, as we need a base path to start collecting filesystem events, I'm investigating if we could get rid of this for better UX About pattern for folder: develop:
watch:
- path: app
include: "*/sub"
action: rebuild (see https://docs.docker.com/build/concepts/context/#syntax about actual pattern syntax) |
8ae65f8
to
8d9e288
Compare
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@glours added a dedicated e2e test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What I did
Introduce
include
to only select a subset of files in source path for watch command.Illustration example:
Related issue
closes #12544
see compose-spec/compose-go#747
(not mandatory) A picture of a cute animal, if possible in relation to what you did