publishreject compose file with bind mounts
#12601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glours
reviewed
Mar 4, 2025
pkg/compose/publish.go
Outdated
| for _, config := range project.Services { | ||
| for _, volume := range config.Volumes { | ||
| if volume.Type == types.VolumeTypeBind { | ||
| return false, errors.New("cannot publish a compose file relying on bind-mount. You should use volumes") |
There was a problem hiding this comment.
Maybe we could let the user know which service has a bind mount declared, no?
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
ndeloof
force-pushed
the
publish_bind_mount
branch
from
7f499dc to
3d66451
Compare
glours
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
publishreject compose file with bind mountsCompose file author should rely on volumes to prevent consumer to expose personal data to a potentially untrusted compose stack
Related issue
https://docker.atlassian.net/browse/APCLI-878
(not mandatory) A picture of a cute animal, if possible in relation to what you did