Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: retract v0.9.0 #362

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Conversation

akerouanton
Copy link
Member

- What I did

Commit 4cdcdc2 introduced two regressions in the osxkeychain credential helper, on list and get operations. These were addressed in:

  • Commit c7514a0: osxkeychain: list: do not error out when keychain is empty
  • Commit f4cdabf: osxkeychain: store: use Apple's proto consts

@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.15%. Comparing base (26274da) to head (9651bf7).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #362   +/-   ##
=======================================
  Coverage   50.15%   50.15%           
=======================================
  Files          13       13           
  Lines         650      650           
=======================================
  Hits          326      326           
  Misses        279      279           
  Partials       45       45           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Commit 4cdcdc2 introduced two regressions in the `osxkeychain`
credential helper,  on `list` and `get` operations. These were addressed
in:

- Commit c7514a0: osxkeychain: list: do not error out when keychain is empty
- Commit f4cdabf: osxkeychain: store: use Apple's proto consts

Signed-off-by: Albin Kerouanton <albinker@gmail.com>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akerouanton akerouanton merged commit 833d2c3 into docker:master Feb 28, 2025
12 checks passed
@akerouanton akerouanton deleted the retract-v0.9.0 branch February 28, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants