Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] tests: backward-compatibility with v0.8.2 #365

Closed

Conversation

akerouanton
Copy link
Member

- What I did

We recently introduced bad-looking regressions in v0.9.0. These were not caught by our test suite. This commit adds a new backward_compatibility suite to make sure it doesn't happen again.

- How to verify it

New GHA steps should be green.

@akerouanton akerouanton changed the title [DNM] Test backward-compatibility with v0.8.2 [DNM] tests: backward-compatibility with v0.8.2 Mar 3, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.04%. Comparing base (833d2c3) to head (a3251c4).

❗ There is a different number of reports uploaded between BASE (833d2c3) and HEAD (a3251c4). Click for more details.

HEAD has 13 uploads less than BASE
Flag BASE (833d2c3) HEAD (a3251c4)
14 1
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #365      +/-   ##
==========================================
- Coverage   50.15%   43.04%   -7.12%     
==========================================
  Files          13        9       -4     
  Lines         650      460     -190     
==========================================
- Hits          326      198     -128     
+ Misses        279      233      -46     
+ Partials       45       29      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akerouanton akerouanton force-pushed the test-backward-compatibility branch 13 times, most recently from 02fa467 to 3c02077 Compare March 3, 2025 13:01
Comment on lines 32 to 33
assert.NilError(t, oldErr)
assert.NilError(t, newErr)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think most (if not all) assertions we use a fairly basic; how much work would it be to implement these tests without introducing gotest.tools as dependency? (Mostly trying to keep the list of required dependencies as minimal as possible for this repository).

@akerouanton akerouanton force-pushed the test-backward-compatibility branch 5 times, most recently from 7a3fcfa to 87c89c9 Compare March 3, 2025 17:08
We recently introduced bad-looking regressions in v0.9.0. These were not
caught by our test suite. This commit adds a new
`backward_compatibility` suite to make sure it doesn't happen again.

Signed-off-by: Albin Kerouanton <albinker@gmail.com>
@akerouanton akerouanton force-pushed the test-backward-compatibility branch from 87c89c9 to a3251c4 Compare March 3, 2025 17:10
@akerouanton
Copy link
Member Author

Tests are timing out on macOS due to the keychain being locked, and macOS displaying the GUI popup that requests password. I can't find a proper way to bypass that -- maybe security authorizationdb write … could do the job but the list of keys it accepts are undocumented and are subject to change across (major) macOS versions.

In retrospect, having tests that ensure backward compatibility is no different than a proper suite of conformance tests, plus human review ensuring tests aren't inadequately changed across versions. Of course, this means we can't ensure backward compatibility between version N (eg. v0.9.2) and version N-1 (eg. v0.8.2), but going forward it should be okay.

So, I'll abandon this PR and work on a shared suite of conformance tests instead.

@akerouanton akerouanton closed this Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants