Skip to content

Commit 1278c5b

Browse files
authored
Update example in the Compose Build Specification (additional_contexts) to ease it's understanding (#22140)
There might by a slight error when illustrating the `additional_contexts` attribute. The compose file declares two services with the same name. It might induce misunderstanding, especially since the second service's image uses the first one to build upon. ## Description I replaced the key defining the second service of the compose file used to illustrate the `additional_contexts` attribute, since the key `base` is used twice. Of course, any better replacement could be used, instead of `my-service`. It is invalid to use the same key twice (the error: `mapping key "base" already defined at line 2` is expected on `docker compose up`), and it does harm the understanding of the illustrated point of building a service's image using another one to share layers. ## Reviews <!-- Notes for reviewers here --> <!-- List applicable reviews (optionally @tag reviewers) --> - [ ] Technical review - [ ] Editorial review - [ ] Product review
1 parent a0cb5a7 commit 1278c5b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

content/reference/compose-file/build.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ services:
130130
dockerfile_inline: |
131131
FROM alpine
132132
RUN ...
133-
base:
133+
my-service:
134134
build:
135135
context: .
136136
dockerfile_inline: |

0 commit comments

Comments
 (0)