Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix anchor locations #14060

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

halkeye
Copy link

@halkeye halkeye commented Dec 30, 2021

Proposed changes

Currently, if you go to https://docs.docker.com/compose/release-notes/#1290 the header (h*) is actually cutover by the header (top bar).

Ex: https://docs.docker.com/compose/release-notes/#1290

image

vs

image

Unreleased project version (optional)

N/A: Pure docs site change

Related issues (optional)

N/A

@netlify
Copy link

netlify bot commented Dec 30, 2021

✔️ Deploy Preview for docsdocker ready!

🔨 Explore the source changes: 03cee09

🔍 Inspect the deploy log: https://app.netlify.com/sites/docsdocker/deploys/61ce1a90cd0d5800076a7074

😎 Browse the preview: https://deploy-preview-14060--docsdocker.netlify.app

brianrobt
brianrobt previously approved these changes Dec 30, 2021
Copy link

@brianrobt brianrobt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@halkeye
Copy link
Author

halkeye commented Dec 31, 2021

https://deploy-preview-14060--docsdocker.netlify.app/compose/release-notes/#1290 looks the same to me as https://docs.docker.com/compose/release-notes/#1290 ?

it does look like when coming in from external site, it does sorta work, but when you click on the chain icon next to header, it jumps to under the topbar.

@halkeye
Copy link
Author

halkeye commented Dec 31, 2021

@thaJeztah
Copy link
Member

Thanks for looking into this; yes, I recall the layout was a bit quirky in this area and collected a good amount of legacy code, css, and "oh,let's apply a quick hack here and there" over the years. I tried to clean up some of that, but it's been a good 7 years or so since I did any front-end work 😅, so there may be some remaining issues (ideally, we should do a good cleanup / overhaul / rewrite of the docs "theme").

I'll try to reserve some time soon to have a look at your changes, and to check if it doesn't affect some of the other "hacks" that are in place 😬

@thaJeztah thaJeztah self-assigned this Jan 6, 2022
@halkeye
Copy link
Author

halkeye commented Jan 7, 2022

We essentially had the same issue on jenkins.io which Is how I learned about it. I think with this you can probably safely get rid of most of the hacks, but I didn't want to mess with very much, CSS tends to be brittle on long running sites :)

@craig-osterhout craig-osterhout added the area/ux Issue affects functionality of docs.docker.com label Aug 4, 2022
@docker-robott
Copy link
Collaborator

Thanks for the pull request. We'd like to make our product docs better, but haven’t been able to review all the suggestions.
As our docs have also diverged, we do not have the bandwidth to review and rebase old pull requests.

If the updates are still relevant, review our contribution guidelines and rebase your pull request against the latest version of the docs, then mark it as fresh with a /remove-lifecycle stale comment.
If not, this pull request will be closed in 30 days. This helps our maintainers focus on the active pull requests.

Prevent pull requests from auto-closing with a /lifecycle frozen comment.

/lifecycle stale

@netlify
Copy link

netlify bot commented Nov 26, 2022

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 6facfd0
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/638197e10d13ba00091dd6e4
😎 Deploy Preview https://deploy-preview-14060--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@halkeye
Copy link
Author

halkeye commented Nov 26, 2022

/remove-lifecycle stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ux Issue affects functionality of docs.docker.com lifecycle/frozen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants