-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix anchor locations #14060
base: main
Are you sure you want to change the base?
Fix anchor locations #14060
Conversation
✔️ Deploy Preview for docsdocker ready! 🔨 Explore the source changes: 03cee09 🔍 Inspect the deploy log: https://app.netlify.com/sites/docsdocker/deploys/61ce1a90cd0d5800076a7074 😎 Browse the preview: https://deploy-preview-14060--docsdocker.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
it does look like when coming in from external site, it does sorta work, but when you click on the chain icon next to header, it jumps to under the topbar. |
So my guess is that its https://github.com/docker/docker.github.io/blob/master/js/docs.js#L165 |
Thanks for looking into this; yes, I recall the layout was a bit quirky in this area and collected a good amount of legacy code, css, and "oh,let's apply a quick hack here and there" over the years. I tried to clean up some of that, but it's been a good 7 years or so since I did any front-end work 😅, so there may be some remaining issues (ideally, we should do a good cleanup / overhaul / rewrite of the docs "theme"). I'll try to reserve some time soon to have a look at your changes, and to check if it doesn't affect some of the other "hacks" that are in place 😬 |
We essentially had the same issue on jenkins.io which Is how I learned about it. I think with this you can probably safely get rid of most of the hacks, but I didn't want to mess with very much, CSS tends to be brittle on long running sites :) |
Thanks for the pull request. We'd like to make our product docs better, but haven’t been able to review all the suggestions. If the updates are still relevant, review our contribution guidelines and rebase your pull request against the latest version of the docs, then mark it as fresh with a Prevent pull requests from auto-closing with a /lifecycle stale |
03cee09
to
6facfd0
Compare
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
/remove-lifecycle stale |
Proposed changes
Currently, if you go to https://docs.docker.com/compose/release-notes/#1290 the header (h*) is actually cutover by the header (top bar).
Ex: https://docs.docker.com/compose/release-notes/#1290
vs
Unreleased project version (optional)
N/A: Pure docs site change
Related issues (optional)
N/A