Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENGDOCS-2451 #22117

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

ENGDOCS-2451 #22117

wants to merge 7 commits into from

Conversation

aevesdocker
Copy link
Contributor

@aevesdocker aevesdocker commented Feb 27, 2025 •
edited
Loading

Description

  • Gets the DD troubleshoot page into new format
  • Moves some FAQs into troubleshoot section
  • Removes a redundant page
  • Freshness on the pages
  • Freshness and tidy on DD FAQs as well

Am choosing to ignore Vale at this time

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

@github-actions github-actions bot added the area/desktop Issue affects a desktop edition of Docker. E.g docker for mac label Feb 27, 2025
@netlify Netlify
Copy link

netlify bot commented Feb 27, 2025 •
edited
Loading

✅ Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 4fe3e95
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/67c6f417d518cf00081a97d7
😎 Deploy Preview https://deploy-preview-22117--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added area/get-started Relates to get started and onboarding docs area/guides labels Feb 28, 2025
@aevesdocker aevesdocker marked this pull request as ready for review February 28, 2025 10:25
@aevesdocker aevesdocker requested a review from a team February 28, 2025 10:25
sarahsanders-docker
sarahsanders-docker requested changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@sarahsanders-docker sarahsanders-docker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! I left one comment about using "Issue:" in the headings, this is totally my bad for not deleting that in the template, and one little nit for a missing ####Cause

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahsanders-docker sarahsanders-docker

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
area/desktop Issue affects a desktop edition of Docker. E.g docker for mac area/get-started Relates to get started and onboarding docs area/guides status/review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aevesdocker @sarahsanders-docker