Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support running vale locally #22130

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mdelapenya
Copy link
Member

@mdelapenya mdelapenya commented Feb 28, 2025

  • chore: add a make goal to run the validations
  • feat: add a make goal to run vale locally

Description

This PR adds two Make goals:

  • make vale, which runs vale as a container using the official Vale Docker image.
  • make validate, which runs docker buildx bake validate

The first one allows contributors to detect grammar errors while working on their changes, and the second is an alias for the build command.

The intention here is to enhance the local development experience when contributing to the docs, not having to wait for the CI to understand the vale errors, but instead making it possible to run it locally.

Reviews

  • Technical review
  • Editorial review
  • Product review

@github-actions github-actions bot added area/contrib Relates to the Docker style guide and contribution guidelines area/config labels Feb 28, 2025
Copy link

netlify bot commented Feb 28, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 181090e
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/67c19cddd7a6e70008dda35e
😎 Deploy Preview https://deploy-preview-22130--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aevesdocker aevesdocker requested review from a team, thaJeztah and crazy-max February 28, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config area/contrib Relates to the Docker style guide and contribution guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant