publish updates from main #22137
Merged
publish updates from main #22137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
<!--Delete sections as needed --> ## Description <!-- Tell us what you did and why --> Fix a few grammar and spelling errors. ## Reviews <!-- Notes for reviewers here --> <!-- List applicable reviews (optionally @tag reviewers) --> - [ ] Technical review - [ ] Editorial review - [ ] Product review
github-actions
bot
requested review from
thaJeztah and
aevesdocker
as code owners
docs(manuals): use canonical compose.yaml filename
…s) to ease it's understanding (#22140) There might by a slight error when illustrating the `additional_contexts` attribute. The compose file declares two services with the same name. It might induce misunderstanding, especially since the second service's image uses the first one to build upon. ## Description I replaced the key defining the second service of the compose file used to illustrate the `additional_contexts` attribute, since the key `base` is used twice. Of course, any better replacement could be used, instead of `my-service`. It is invalid to use the same key twice (the error: `mapping key "base" already defined at line 2` is expected on `docker compose up`), and it does harm the understanding of the illustrated point of building a service's image using another one to share layers. ## Reviews <!-- Notes for reviewers here --> <!-- List applicable reviews (optionally @tag reviewers) --> - [ ] Technical review - [ ] Editorial review - [ ] Product review
- **chore: add testcontainers entry in the OSS section of Manuals** - **chore: adds quickstarts for tc-go and tc-java** <!--Delete sections as needed --> ## Description This PR adds the Testcontainers OSS section in the Manuals > OSS section of the docs. It's adding the following pages: - index page with a basic description of the project, with two cards: - why use testcontainers, linking to a benefits page - quicktart, linking to a folder with two pages: Go and Java Below the cards grid, it links to the testcontainers.com/getting-started page. The benefits page includes some of the content of the above getting-started page, and the Go and Java quickstart pages are copying the quickstart pages from Go (https://golang.testcontainers.org/quickstart/) and Java (https://java.testcontainers.org/quickstart/) in its 3 flavours (junit4, junit5 and spock) <!-- Tell us what you did and why --> ## Related issues or tickets <!-- Related issues, pull requests, or Jira tickets --> ## Reviews <!-- Notes for reviewers here --> <!-- List applicable reviews (optionally @tag reviewers) --> - [x] Technical review - [ ] Editorial review - [x] Product review --------- Co-authored-by: aevesdocker <allie.sadler@docker.com>
`x-initialSync` was misspelled as `x-initSync`, which can be frustrating for users. Ref https://github.com/docker/compose/blob/876ecc48be0fe0ab74b23c6333ed20271438c1b4/pkg/compose/watch.go#L170 and docker/compose#11102 (comment)
aevesdocker
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated pull request for publishing docs updates.