Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publish updates from main #22137

Merged
merged 6 commits into from
Mar 3, 2025
Merged

publish updates from main #22137

merged 6 commits into from
Mar 3, 2025

Conversation

github-actions[bot]
Copy link

Automated pull request for publishing docs updates.

<!--Delete sections as needed -->

## Description

<!-- Tell us what you did and why -->

Fix a few grammar and spelling errors.


## Reviews

<!-- Notes for reviewers here -->
<!-- List applicable reviews (optionally @tag reviewers) -->

- [ ] Technical review
- [ ] Editorial review
- [ ] Product review
@github-actions github-actions bot added the area/release Relates to CI or deployment label Feb 28, 2025
docs(manuals): use canonical compose.yaml filename
@github-actions github-actions bot requested a review from crazy-max as a code owner March 3, 2025 09:23
fbukevin and others added 4 commits March 3, 2025 09:29
## Description

Fixed typo im content/manuals/engine/swarm/swarm-mode.md. 


## Related issues or tickets

Issue #22121

## Reviews

<!-- Notes for reviewers here -->
<!-- List applicable reviews (optionally @tag reviewers) -->

- [ ] Technical review
- [ ] Editorial review
- [ ] Product review
…s) to ease it's understanding (#22140)

There might by a slight error when illustrating the
`additional_contexts` attribute. The compose file declares two services
with the same name. It might induce misunderstanding, especially since
the second service's image uses the first one to build upon.

## Description

I replaced the key defining the second service of the compose file used
to illustrate the `additional_contexts` attribute, since the key `base`
is used twice. Of course, any better replacement could be used, instead
of `my-service`.

It is invalid to use the same key twice (the error: `mapping key "base"
already defined at line 2` is expected on `docker compose up`), and it
does harm the understanding of the illustrated point of building a
service's image using another one to share layers.

## Reviews

<!-- Notes for reviewers here -->
<!-- List applicable reviews (optionally @tag reviewers) -->

- [ ] Technical review
- [ ] Editorial review
- [ ] Product review
- **chore: add testcontainers entry in the OSS section of Manuals**
- **chore: adds quickstarts for tc-go and tc-java**

<!--Delete sections as needed -->

## Description
This PR adds the Testcontainers OSS section in the Manuals > OSS section
of the docs.

It's adding the following pages:

- index page with a basic description of the project, with two cards:
  - why use testcontainers, linking to a benefits page
  - quicktart, linking to a folder with two pages: Go and Java

Below the cards grid, it links to the testcontainers.com/getting-started
page.

The benefits page includes some of the content of the above
getting-started page, and the Go and Java quickstart pages are copying
the quickstart pages from Go
(https://golang.testcontainers.org/quickstart/) and Java
(https://java.testcontainers.org/quickstart/) in its 3 flavours (junit4,
junit5 and spock)

<!-- Tell us what you did and why -->

## Related issues or tickets

<!-- Related issues, pull requests, or Jira tickets -->

## Reviews

<!-- Notes for reviewers here -->
<!-- List applicable reviews (optionally @tag reviewers) -->

- [x] Technical review
- [ ] Editorial review
- [x] Product review

---------

Co-authored-by: aevesdocker <allie.sadler@docker.com>
@aevesdocker aevesdocker merged commit 645ec54 into published Mar 3, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/release Relates to CI or deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants