Skip to content

Commit

Permalink
Remove buggy debounce from seret setter
Browse files Browse the repository at this point in the history
  • Loading branch information
ColinMcNeil committed Mar 4, 2025
1 parent 180cf98 commit 03ecf01
Showing 1 changed file with 4 additions and 29 deletions.
33 changes: 4 additions & 29 deletions src/extension/ui/src/components/CatalogGrid.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -26,28 +26,6 @@ const filterCatalog = (catalogItems: CatalogItemWithName[], registryItems: { [ke

const NEVER_SHOW_AGAIN_KEY = 'registry-sync-never-show-again';

const debounce = (func: (...args: any[]) => Promise<void>, wait: number, immediate: boolean) => {
let timeout: NodeJS.Timeout | null = null;
return function (...args: any[]) {
return new Promise((resolve) => {
if (timeout) {
clearTimeout(timeout);
}
timeout = setTimeout(() => {
timeout = null
if (!immediate) {
// @ts-expect-error
Promise.resolve(func.apply(this as any, [...args])).then(resolve)
}
}, wait)
if (immediate && !timeout) {
// @ts-expect-error
Promise.resolve(func.apply(this as any, [...args])).then(resolve)
}
})
}
}

export const CatalogGrid: React.FC<CatalogGridProps> = ({
registryItems,
canRegister,
Expand Down Expand Up @@ -95,11 +73,6 @@ export const CatalogGrid: React.FC<CatalogGridProps> = ({
setSecrets(response || []);
}

const debouncedAddSecret = debounce(async (client: v1.DockerDesktopClient, name: string, value: string) => {
await Secrets.addSecret(client, { name, value, policies: [MCP_POLICY_NAME] })
loadSecrets();
}, 1000, false);

const registerCatalogItem = async (item: CatalogItemWithName) => {
try {
const currentRegistry = await getRegistry(client);
Expand Down Expand Up @@ -220,7 +193,8 @@ export const CatalogGrid: React.FC<CatalogGridProps> = ({
register={registerCatalogItem}
unregister={unregisterCatalogItem}
onSecretChange={async (secret) => {
await debouncedAddSecret(client, secret.name, secret.value);
await Secrets.addSecret(client, { name: secret.name, value: secret.value, policies: [MCP_POLICY_NAME] })
loadSecrets();
}}
secrets={secrets}
/>
Expand All @@ -244,7 +218,8 @@ export const CatalogGrid: React.FC<CatalogGridProps> = ({
<CatalogItemCard item={catalogItems.find((i) => i.name === name)!} openUrl={() => {
client.host.openExternal(Ref.fromRef(item.ref).toURL(true));
}} canRegister={canRegister} registered={true} register={registerCatalogItem} unregister={unregisterCatalogItem} onSecretChange={async (secret) => {
debouncedAddSecret(client, secret.name, secret.value);
await Secrets.addSecret(client, { name: secret.name, value: secret.value, policies: [MCP_POLICY_NAME] })
loadSecrets();
}} secrets={secrets} />
</Grid2>
))}
Expand Down

0 comments on commit 03ecf01

Please sign in to comment.