feat: bundle secret management API client #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe0BAB
commented
Mar 3, 2025
| Value string | ||
| } | ||
|
|
||
| func AddSecret(ctx context.Context) *cobra.Command { |
There was a problem hiding this comment.
This should be good enough for the start. Just run host-binary add --name <secret-name> --value <secret-value>. (you can adjust to your needs later if you want)
joe0BAB
commented
Mar 3, 2025
| } | ||
|
|
||
| func assertMcpPolicyExists(ctx context.Context, apiClient client.ApiClient) error { | ||
| return apiClient.SetPolicy(ctx, secretsapi.Policy{Name: mcpPolicyName, Images: []string{"*"}}) |
There was a problem hiding this comment.
Every time we add a secret, we assure the MCP policy exists and is set to * so any image can consume the secrets.
joe0BAB
commented
Mar 3, 2025
| @@ -18,7 +25,7 @@ update-extension: build-extension ## Update the extension | |||
| prepare-buildx: ## Create buildx builder for multi-arch build, if not exists | |||
| docker buildx inspect $(BUILDER) || docker buildx create --name=$(BUILDER) --driver=docker-container --driver-opt=network=host | |||
|
|
|||
| push-extension: prepare-buildx ## Build & Upload extension image to hub. Do not push if tag already exists: make push-extension tag=0.1 | |||
| push-extension: prepare-buildx cross ## Build & Upload extension image to hub. Do not push if tag already exists: make push-extension tag=0.1 | |||
There was a problem hiding this comment.
The host-binary dir has its own Makefile. Hooking in the cross target here should be enough to next time ship an extension with the client host binary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.