Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add a registry: parameter #76

Closed
justinmchase opened this issue Mar 20, 2023 · 1 comment
Closed

Please add a registry: parameter #76

justinmchase opened this issue Mar 20, 2023 · 1 comment

Comments

@justinmchase
Copy link

justinmchase commented Mar 20, 2023

Behaviour

I have to use a corporate proxy (jfrog artifactory). This image attempts to pull from public docker hub (docker.io) by default and the way to configure an alternate registry differs from other docker actions.

The docker/login-action action has a registry parameter. This one for some reason only has an image: parameter. I was able to just alter the image value to have the full path to our internal proxy but it definitely made me stop and have to go look up the docs rather than just having all of the docker images have the same input parameters.

A couple of developers took 30m trying to figure out why the registry: parameter wasn't working like the other action only to find out they're just both different. Consistency across actions would help quite a bit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants