Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/source-build-reference-packages #60601

Merged
merged 11 commits into from
Mar 5, 2025
Merged

[main] Update dependencies from dotnet/source-build-reference-packages #60601

merged 11 commits into from
Mar 5, 2025

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Feb 25, 2025 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/source-build-reference-packages

@dotnet-maestro
Update dependencies from https://github.com/dotnet/source-build-refer…
d0417ff 
…ence-packages build 20250224.2

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 10.0.611901 -> To Version 10.0.612402
@dotnet-maestro dotnet-maestro bot requested review from wtgodbe and a team as code owners February 25, 2025 05:02
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Feb 25, 2025
dotnet-policy-service[bot]
dotnet-policy-service bot approved these changes Feb 25, 2025
View reviewed changes
Copy link
Contributor

@dotnet-policy-service dotnet-policy-service bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving dependency update.

@dotnet-maestro
Update dependencies from https://github.com/dotnet/source-build-refer…
b24beb3 
…ence-packages build 20250225.2

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 10.0.611901 -> To Version 10.0.612502
@SteveSandersonMS
Copy link
Member

SteveSandersonMS commented Feb 27, 2025 •
edited
Loading

@dotnet/source-build The failure here is:

.packages/microsoft.dotnet.arcade.sdk/10.0.0-beta.25106.4/tools/SourceBuild/AfterSourceBuild.proj(83,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 4 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/sb/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
System.Buffers.4.4.0
System.Collections.Immutable.1.5.0
System.Memory.4.5.3
System.Reflection.Metadata.1.6.0

The prebuild-usage is:

prebuild-usage 
<UsageData>
<ProjectDirectories>
<Dir>src/</Dir>
<Dir/>
</ProjectDirectories>
<Usages>
<Usage Id="Microsoft.CodeAnalysis.Analyzers" Version="2.9.4" File="src/artifacts/obj/Microsoft.AspNetCore.Analyzers/project.assets.json"/>
<Usage Id="Microsoft.CodeAnalysis.Analyzers" Version="2.9.4" File="src/artifacts/obj/Microsoft.AspNetCore.Components.Analyzers/project.assets.json"/>
<Usage Id="Microsoft.CodeAnalysis.Analyzers" Version="2.9.4" File="src/artifacts/obj/Microsoft.AspNetCore.Components.SdkAnalyzers/project.assets.json"/>
<Usage Id="Microsoft.CodeAnalysis.Analyzers" Version="2.9.4" File="src/artifacts/obj/Microsoft.AspNetCore.Mvc.Analyzers/project.assets.json"/>
<Usage Id="Microsoft.CodeAnalysis.Analyzers" Version="2.9.4" File="src/artifacts/obj/Microsoft.AspNetCore.Mvc.Api.Analyzers/project.assets.json"/>
<Usage Id="Microsoft.CodeAnalysis.AnalyzerUtilities" Version="3.3.0" File="src/artifacts/obj/Microsoft.AspNetCore.App.Analyzers/project.assets.json"/>
<Usage Id="Microsoft.CodeAnalysis.AnalyzerUtilities" Version="3.3.0" File="src/artifacts/obj/Microsoft.AspNetCore.App.CodeFixes/project.assets.json"/>
<Usage Id="Microsoft.CodeAnalysis.Common" Version="3.3.1" File="src/artifacts/obj/Microsoft.AspNetCore.Analyzers/project.assets.json"/>
<Usage Id="Microsoft.CodeAnalysis.Common" Version="3.3.1" File="src/artifacts/obj/Microsoft.AspNetCore.Components.Analyzers/project.assets.json"/>
<Usage Id="Microsoft.CodeAnalysis.Common" Version="3.3.1" File="src/artifacts/obj/Microsoft.AspNetCore.Components.SdkAnalyzers/project.assets.json"/>
<Usage Id="Microsoft.CodeAnalysis.Common" Version="3.3.1" File="src/artifacts/obj/Microsoft.AspNetCore.Mvc.Analyzers/project.assets.json"/>
<Usage Id="Microsoft.CodeAnalysis.Common" Version="3.3.1" File="src/artifacts/obj/Microsoft.AspNetCore.Mvc.Api.Analyzers/project.assets.json"/>
<Usage Id="Microsoft.CodeAnalysis.CSharp" Version="3.3.1" File="src/artifacts/obj/Microsoft.AspNetCore.Analyzers/project.assets.json" IsDirectDependency="true" IsAutoReferenced="true"/>
<Usage Id="Microsoft.CodeAnalysis.CSharp" Version="3.3.1" File="src/artifacts/obj/Microsoft.AspNetCore.Components.Analyzers/project.assets.json"/>
<Usage Id="Microsoft.CodeAnalysis.CSharp" Version="3.3.1" File="src/artifacts/obj/Microsoft.AspNetCore.Components.SdkAnalyzers/project.assets.json"/>
<Usage Id="Microsoft.CodeAnalysis.CSharp" Version="3.3.1" File="src/artifacts/obj/Microsoft.AspNetCore.Mvc.Analyzers/project.assets.json" IsDirectDependency="true" IsAutoReferenced="true"/>
<Usage Id="Microsoft.CodeAnalysis.CSharp" Version="3.3.1" File="src/artifacts/obj/Microsoft.AspNetCore.Mvc.Api.Analyzers/project.assets.json"/>
<Usage Id="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="3.3.1" File="src/artifacts/obj/Microsoft.AspNetCore.Components.Analyzers/project.assets.json" IsDirectDependency="true" IsAutoReferenced="true"/>
<Usage Id="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="3.3.1" File="src/artifacts/obj/Microsoft.AspNetCore.Components.SdkAnalyzers/project.assets.json" IsDirectDependency="true" IsAutoReferenced="true"/>
<Usage Id="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="3.3.1" File="src/artifacts/obj/Microsoft.AspNetCore.Mvc.Api.Analyzers/project.assets.json" IsDirectDependency="true" IsAutoReferenced="true"/>
<Usage Id="Microsoft.CodeAnalysis.Workspaces.Common" Version="3.3.1" File="src/artifacts/obj/Microsoft.AspNetCore.Components.Analyzers/project.assets.json"/>
<Usage Id="Microsoft.CodeAnalysis.Workspaces.Common" Version="3.3.1" File="src/artifacts/obj/Microsoft.AspNetCore.Components.SdkAnalyzers/project.assets.json"/>
<Usage Id="Microsoft.CodeAnalysis.Workspaces.Common" Version="3.3.1" File="src/artifacts/obj/Microsoft.AspNetCore.Mvc.Api.Analyzers/project.assets.json"/>
<Usage Id="Microsoft.DiaSymReader" Version="2.0.0" File="src/artifacts/obj/Microsoft.AspNetCore.App.Analyzers/project.assets.json"/>
<Usage Id="Microsoft.DiaSymReader" Version="2.0.0" File="src/artifacts/obj/Microsoft.AspNetCore.App.CodeFixes/project.assets.json"/>
<Usage Id="Microsoft.NETCore.App.Crossgen2.linux-x64" Version="10.0.0-preview.3.25124.11"/>
<Usage Id="NuGet.Common" Version="6.2.4" File="src/artifacts/obj/RepoTasks/project.assets.json"/>
<Usage Id="NuGet.Configuration" Version="6.2.4" File="src/artifacts/obj/RepoTasks/project.assets.json"/>
<Usage Id="NuGet.Frameworks" Version="6.2.4" File="src/artifacts/obj/RepoTasks/project.assets.json"/>
<Usage Id="NuGet.Packaging" Version="6.2.4" File="src/artifacts/obj/RepoTasks/project.assets.json" IsDirectDependency="true"/>
<Usage Id="NuGet.Versioning" Version="6.2.4" File="src/artifacts/obj/RepoTasks/project.assets.json"/>
<Usage Id="System.Buffers" Version="4.4.0" File="src/artifacts/obj/Microsoft.AspNetCore.Analyzers/project.assets.json"/>
<Usage Id="System.Buffers" Version="4.4.0" File="src/artifacts/obj/Microsoft.AspNetCore.Components.Analyzers/project.assets.json"/>
<Usage Id="System.Buffers" Version="4.4.0" File="src/artifacts/obj/Microsoft.AspNetCore.Components.SdkAnalyzers/project.assets.json"/>
<Usage Id="System.Buffers" Version="4.4.0" File="src/artifacts/obj/Microsoft.AspNetCore.Mvc.Analyzers/project.assets.json"/>
<Usage Id="System.Buffers" Version="4.4.0" File="src/artifacts/obj/Microsoft.AspNetCore.Mvc.Api.Analyzers/project.assets.json"/>
<Usage Id="System.Collections.Immutable" Version="1.5.0" File="src/artifacts/obj/Microsoft.AspNetCore.Analyzers/project.assets.json"/>
<Usage Id="System.Collections.Immutable" Version="1.5.0" File="src/artifacts/obj/Microsoft.AspNetCore.Components.Analyzers/project.assets.json"/>
<Usage Id="System.Collections.Immutable" Version="1.5.0" File="src/artifacts/obj/Microsoft.AspNetCore.Components.SdkAnalyzers/project.assets.json"/>
<Usage Id="System.Collections.Immutable" Version="1.5.0" File="src/artifacts/obj/Microsoft.AspNetCore.Mvc.Analyzers/project.assets.json"/>
<Usage Id="System.Collections.Immutable" Version="1.5.0" File="src/artifacts/obj/Microsoft.AspNetCore.Mvc.Api.Analyzers/project.assets.json"/>
<Usage Id="System.Composition" Version="1.0.31" File="src/artifacts/obj/Microsoft.AspNetCore.Components.Analyzers/project.assets.json"/>
<Usage Id="System.Composition" Version="1.0.31" File="src/artifacts/obj/Microsoft.AspNetCore.Components.SdkAnalyzers/project.assets.json"/>
<Usage Id="System.Composition" Version="1.0.31" File="src/artifacts/obj/Microsoft.AspNetCore.Mvc.Api.Analyzers/project.assets.json"/>
<Usage Id="System.Composition" Version="8.0.0" File="src/artifacts/obj/Microsoft.AspNetCore.App.Analyzers/project.assets.json"/>
<Usage Id="System.Composition" Version="8.0.0" File="src/artifacts/obj/Microsoft.AspNetCore.App.CodeFixes/project.assets.json"/>
<Usage Id="System.Composition" Version="8.0.0" File="src/artifacts/obj/Microsoft.AspNetCore.App.SourceGenerators/project.assets.json"/>
<Usage Id="System.Composition.AttributedModel" Version="8.0.0" File="src/artifacts/obj/Microsoft.AspNetCore.App.Analyzers/project.assets.json"/>
<Usage Id="System.Composition.AttributedModel" Version="8.0.0" File="src/artifacts/obj/Microsoft.AspNetCore.App.CodeFixes/project.assets.json"/>
<Usage Id="System.Composition.AttributedModel" Version="8.0.0" File="src/artifacts/obj/Microsoft.AspNetCore.App.SourceGenerators/project.assets.json"/>
<Usage Id="System.Composition.Convention" Version="8.0.0" File="src/artifacts/obj/Microsoft.AspNetCore.App.Analyzers/project.assets.json"/>
<Usage Id="System.Composition.Convention" Version="8.0.0" File="src/artifacts/obj/Microsoft.AspNetCore.App.CodeFixes/project.assets.json"/>
<Usage Id="System.Composition.Convention" Version="8.0.0" File="src/artifacts/obj/Microsoft.AspNetCore.App.SourceGenerators/project.assets.json"/>
<Usage Id="System.Composition.Hosting" Version="8.0.0" File="src/artifacts/obj/Microsoft.AspNetCore.App.Analyzers/project.assets.json"/>
<Usage Id="System.Composition.Hosting" Version="8.0.0" File="src/artifacts/obj/Microsoft.AspNetCore.App.CodeFixes/project.assets.json"/>
<Usage Id="System.Composition.Hosting" Version="8.0.0" File="src/artifacts/obj/Microsoft.AspNetCore.App.SourceGenerators/project.assets.json"/>
<Usage Id="System.Composition.Runtime" Version="8.0.0" File="src/artifacts/obj/Microsoft.AspNetCore.App.Analyzers/project.assets.json"/>
<Usage Id="System.Composition.Runtime" Version="8.0.0" File="src/artifacts/obj/Microsoft.AspNetCore.App.CodeFixes/project.assets.json"/>
<Usage Id="System.Composition.Runtime" Version="8.0.0" File="src/artifacts/obj/Microsoft.AspNetCore.App.SourceGenerators/project.assets.json"/>
<Usage Id="System.Composition.TypedParts" Version="8.0.0" File="src/artifacts/obj/Microsoft.AspNetCore.App.Analyzers/project.assets.json"/>
<Usage Id="System.Composition.TypedParts" Version="8.0.0" File="src/artifacts/obj/Microsoft.AspNetCore.App.CodeFixes/project.assets.json"/>
<Usage Id="System.Composition.TypedParts" Version="8.0.0" File="src/artifacts/obj/Microsoft.AspNetCore.App.SourceGenerators/project.assets.json"/>
<Usage Id="System.IO.Pipelines" Version="8.0.0" File="src/artifacts/obj/Microsoft.AspNetCore.App.Analyzers/project.assets.json"/>
<Usage Id="System.IO.Pipelines" Version="8.0.0" File="src/artifacts/obj/Microsoft.AspNetCore.App.CodeFixes/project.assets.json"/>
<Usage Id="System.IO.Pipelines" Version="8.0.0" File="src/artifacts/obj/Microsoft.AspNetCore.App.SourceGenerators/project.assets.json"/>
<Usage Id="System.Memory" Version="4.5.3" File="src/artifacts/obj/Microsoft.AspNetCore.Analyzers/project.assets.json"/>
<Usage Id="System.Memory" Version="4.5.3" File="src/artifacts/obj/Microsoft.AspNetCore.Components.Analyzers/project.assets.json"/>
<Usage Id="System.Memory" Version="4.5.3" File="src/artifacts/obj/Microsoft.AspNetCore.Components.SdkAnalyzers/project.assets.json"/>
<Usage Id="System.Memory" Version="4.5.3" File="src/artifacts/obj/Microsoft.AspNetCore.Mvc.Analyzers/project.assets.json"/>
<Usage Id="System.Memory" Version="4.5.3" File="src/artifacts/obj/Microsoft.AspNetCore.Mvc.Api.Analyzers/project.assets.json"/>
<Usage Id="System.Reflection.Metadata" Version="1.6.0" File="src/artifacts/obj/Microsoft.AspNetCore.Analyzers/project.assets.json"/>
<Usage Id="System.Reflection.Metadata" Version="1.6.0" File="src/artifacts/obj/Microsoft.AspNetCore.Components.Analyzers/project.assets.json"/>
<Usage Id="System.Reflection.Metadata" Version="1.6.0" File="src/artifacts/obj/Microsoft.AspNetCore.Components.SdkAnalyzers/project.assets.json"/>
<Usage Id="System.Reflection.Metadata" Version="1.6.0" File="src/artifacts/obj/Microsoft.AspNetCore.Mvc.Analyzers/project.assets.json"/>
<Usage Id="System.Reflection.Metadata" Version="1.6.0" File="src/artifacts/obj/Microsoft.AspNetCore.Mvc.Api.Analyzers/project.assets.json"/>
<Usage Id="System.Security.Cryptography.Pkcs" Version="5.0.0"/>
<Usage Id="System.Threading.Tasks.Extensions" Version="4.5.3" File="src/artifacts/obj/Microsoft.AspNetCore.Analyzers/project.assets.json"/>
<Usage Id="System.Threading.Tasks.Extensions" Version="4.5.3" File="src/artifacts/obj/Microsoft.AspNetCore.Components.Analyzers/project.assets.json"/>
<Usage Id="System.Threading.Tasks.Extensions" Version="4.5.3" File="src/artifacts/obj/Microsoft.AspNetCore.Components.SdkAnalyzers/project.assets.json"/>
<Usage Id="System.Threading.Tasks.Extensions" Version="4.5.3" File="src/artifacts/obj/Microsoft.AspNetCore.Mvc.Analyzers/project.assets.json"/>
<Usage Id="System.Threading.Tasks.Extensions" Version="4.5.3" File="src/artifacts/obj/Microsoft.AspNetCore.Mvc.Api.Analyzers/project.assets.json"/>
</Usages>
</UsageData>

... so it looks like all the new usages are from analyzers.

Are these things we can whitelist?

@ellahathaway
Copy link
Member

@dotnet/source-build The failure here is:

These packages were removed from SBRP with dotnet/source-build-reference-packages#1173 as they aren't used in full source-build.

Full source-build will "lift" the versions to the latest available packages, built from source, as long as the packages and their respective versions are properly defined in Version.Details.xml and Versions.props. It looks like System.Buffers.4.4.0 and System.Memory.4.5.3 need to be added.

After that, to work-around this issue, new entries should be added to https://github.com/dotnet/aspnetcore/blob/main/eng/SourceBuildPrebuiltBaseline.xml.

dotnet-maestro bot and others added 2 commits February 28, 2025 05:01
@dotnet-maestro
Update dependencies from https://github.com/dotnet/source-build-refer…
3a0b09c 
…ence-packages build 20250227.2

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 10.0.611901 -> To Version 10.0.612702
@SteveSandersonMS
Fixes for source build issues
516b4bf
@SteveSandersonMS SteveSandersonMS requested a review from a team as a code owner February 28, 2025 11:34
dotnet-maestro bot and others added 2 commits March 1, 2025 05:02
@dotnet-maestro
Update dependencies from https://github.com/dotnet/source-build-refer…
df03f1e 
…ence-packages build 20250228.4

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 10.0.611901 -> To Version 10.0.612804
@SteveSandersonMS
Merge branch 'main' into darc-main-e4893e14-f6c2-4dae-a11b-2ff4d00b15c9
6f6db70
@SteveSandersonMS SteveSandersonMS enabled auto-merge (squash) March 3, 2025 09:23
dotnet-maestro bot and others added 2 commits March 4, 2025 05:02
@dotnet-maestro
Update dependencies from https://github.com/dotnet/source-build-refer…
c900271 
…ence-packages build 20250303.3

Microsoft.SourceBuild.Intermediate.source-build-reference-packages
 From Version 10.0.611901 -> To Version 10.0.615303
@JamesNK
Merge branch 'main' into darc-main-e4893e14-f6c2-4dae-a11b-2ff4d00b15c9
207cb9e
@JamesNK
Copy link
Member

JamesNK commented Mar 5, 2025

It looks like this is still broken. Error from Build Source-Build (Managed) pipeline:

.packages/microsoft.dotnet.arcade.sdk/10.0.0-beta.25106.4/tools/SourceBuild/AfterSourceBuild.proj(83,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 27 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/sb/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.
Package IDs are:
Microsoft.NETCore.Targets.1.1.0
System.Collections.4.3.0
System.Composition.AttributedModel.1.0.31
System.Composition.Convention.1.0.31
System.Composition.Hosting.1.0.31
System.Composition.Runtime.1.0.31
System.Composition.TypedParts.1.0.31
System.Diagnostics.Debug.4.3.0
System.Diagnostics.Tools.4.3.0
System.Globalization.4.3.0
System.IO.4.3.0
System.Linq.4.3.0
System.Linq.Expressions.4.3.0
System.ObjectModel.4.3.0
System.Reflection.4.3.0
System.Reflection.Emit.4.3.0
System.Reflection.Emit.ILGeneration.4.3.0
System.Reflection.Emit.Lightweight.4.3.0
System.Reflection.Extensions.4.3.0
System.Reflection.Primitives.4.3.0
System.Reflection.TypeExtensions.4.3.0
System.Resources.ResourceManager.4.3.0
System.Runtime.4.3.0
System.Runtime.Extensions.4.3.0
System.Text.Encoding.4.3.0
System.Threading.4.3.0
System.Threading.Tasks.4.3.0

@SteveSandersonMS
Copy link
Member

@JamesNK Looks like more recent dotnet/source-build-reference-packages changes have moved the goalposts further. A lot further, in fact.

Probably best to reconfirm with @ellahathaway that we really should be adding this many prebuilts, or whether in any sense this undermines the concept of source build. Perhaps the fact that all of them are System.* and presumably produced by Microsoft makes them totally fine to add as prebuilts.

@eerhardt
Copy link
Member

eerhardt commented Mar 5, 2025

@dotnet/source-build - Can this PR be assigned to someone to drive to merge?

@build-analysis build-analysis bot mentioned this pull request Mar 5, 2025
Open
3 tasks
@mthalman mthalman self-assigned this Mar 5, 2025
@mthalman
Copy link
Member

mthalman commented Mar 5, 2025

@dotnet/source-build - Can this PR be assigned to someone to drive to merge?

Assigned myself

@mthalman
Copy link
Member

mthalman commented Mar 5, 2025

All the prebuilts are from the Microsoft.CodeAnalysis.Workspaces.Common package. These are no longer defined in SBRP so they are showing up here. They're ok to add to the prebuilt baseline as the Microsoft.CodeAnalysis.Workspaces.Common version will get lifted in the full product build, along with its transitive dependencies. Because all those transitive dependencies are also getting lifted, there's no need to define these as dependencies in Version.Details.xml.

@mthalman mthalman requested a review from ellahathaway March 5, 2025 16:59
@eerhardt
Copy link
Member

eerhardt commented Mar 5, 2025

Thanks @mthalman!

@SteveSandersonMS SteveSandersonMS merged commit e05d6f6 into main Mar 5, 2025
27 checks passed
@SteveSandersonMS SteveSandersonMS deleted the darc-main-e4893e14-f6c2-4dae-a11b-2ff4d00b15c9 branch March 5, 2025 19:28
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview3 milestone Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellahathaway ellahathaway

@dotnet-policy-service dotnet-policy-service[bot]

@wtgodbe wtgodbe

Assignees

@mthalman mthalman

Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Type: Dependency Update 🔼
Projects
None yet
Milestone
10.0-preview3
Development

Successfully merging this pull request may close these issues.
5 participants
@SteveSandersonMS @ellahathaway @JamesNK @eerhardt @mthalman