-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new UseKestel API to the WebApplicationFactory #60635
Open
mkArtakMSFT
wants to merge
9
commits into
main
Choose a base branch
from
mkArtakMSFT/waf
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+375
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an amazing idea! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR introduces an alternative design for enabling real server usage with WebApplicationFactory by adding a new API that leverages Kestrel. Key changes include:
- Adding a new test class (RealServerBackedIntegrationTests.cs) that validates the real server integration.
- Introducing a new WebApplicationFactory subclass (KestrelBasedWapFactory.cs) that automatically enables Kestrel.
- Updating the core WebApplicationFactory implementation to conditionally use a Kestrel server versus the traditional TestServer.
Reviewed Changes
File | Description |
---|---|
src/Mvc/test/Mvc.FunctionalTests/RealServerBackedIntegrationTests.cs | New integration tests for real server backed functionality. |
src/Mvc/test/Mvc.FunctionalTests/KestrelBasedWapFactory.cs | A factory that configures the WebApplicationFactory to use Kestrel. |
src/Mvc/Mvc.Testing/src/WebApplicationFactory.cs | Modifications to support the new UseKestrel API, including updated server creation, client configuration, and error handling. |
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Throw if the UseKestrel() is called after server initialization
halter73
reviewed
Mar 5, 2025
halter73
reviewed
Mar 5, 2025
halter73
reviewed
Mar 5, 2025
Tratcher
reviewed
Mar 7, 2025
- Allow configuring Kestrel options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UseKestrel()
API to the WebApplicationFactory type. The API configures the WAF, so that later during initialization it will use Kestrel, instead of a TestServer for WebHostBuilder-based applications.EnsureServer()
private method toInitialize()
and made it public, so that consumders can call it directly, without the need of creating a client, as in many situations customers didn't need a client to interact with.This is an alternative design to enabling real server usage with WebApplicationFactory, which was considered here: #60247