Unquarantine EventCountersAndMetricsValues and VerifyCountersFireWithCorrectValues #60651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-networking
There was a problem hiding this comment.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
There was a problem hiding this comment.
PR Overview
This PR unquarantines two tests as they have been stable for over 30 days, in order to reflect their reliable behavior.
- Removed the [QuarantinedTest] attribute from the EventCountersAndMetricsValues test.
- Removed the [QuarantinedTest] attribute from the VerifyCountersFireWithCorrectValues test.
Reviewed Changes
| File | Description |
|---|---|
| src/Hosting/Hosting/test/HostingApplicationDiagnosticsTests.cs | Removed the quarantine attribute from the EventCountersAndMetricsValues test. |
| src/Hosting/Hosting/test/Internal/HostingEventSourceTests.cs | Removed the quarantine attribute from the VerifyCountersFireWithCorrectValues test. |
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
wtgodbe
approved these changes
Feb 27, 2025
JamesNK
approved these changes
Feb 27, 2025
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57259
I've checked and EventCountersAndMetricsValues and VerifyCountersFireWithCorrectValues both seem to have passed 289 out of 289 times in the last 30 days, and were flagged
test-fixedover 30 days ago, so I think they qualify for unquarantining.@JamesNK, I think you fixed these. Are you happy for them to be unquarantined now?