Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add partitioned to cookie for SignalR browser testing #60728

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

BrennanConroy
Copy link
Member

Backport of #57997
Test only change.

@BrennanConroy BrennanConroy added the tell-mode Indicates a PR which is being merged during tell-mode label Mar 4, 2025
@BrennanConroy BrennanConroy requested review from wtgodbe and Copilot March 4, 2025 02:01
@BrennanConroy BrennanConroy requested a review from halter73 as a code owner March 4, 2025 02:01
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-signalr Includes: SignalR clients and servers label Mar 4, 2025
@dotnet-policy-service dotnet-policy-service bot added this to the 8.0.x milestone Mar 4, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

Backport PR to enable partitioned cookies for SignalR browser testing on Chromium.

  • Adds the "partitioned" extension to cookie options in the test startup.
  • Updates cookie configuration to support partitioned cookies as required by Chromium.

Reviewed Changes

File Description
src/SignalR/clients/ts/FunctionalTests/Startup.cs Added partitioned extension to cookie options for testing on Chromium

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@joperezr joperezr merged commit dc12b47 into release/8.0 Mar 7, 2025
25 checks passed
@joperezr joperezr deleted the BrennanConroy-patch-1 branch March 7, 2025 17:28
@dotnet-policy-service dotnet-policy-service bot modified the milestones: 8.0.x, 8.0.14 Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-signalr Includes: SignalR clients and servers tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants