Fix use of ReconnectModal in Blazor templates with auto mode and global interactivity #60735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-mvc
oroztocil
added
area-blazor
|
This should be backported to preview 2, if possible. |
|
I re-tested all the template configurations manually. |
There was a problem hiding this comment.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
javiercn
approved these changes
Mar 4, 2025
|
I am also investigating this https://github.com/dotnet/AspNetCore-ManualTests/issues/3489. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two issues with
ReconnectModalin the Blazor project template:--interactivity autoand--all-interactive(aka global interactivity) use different file structure. This fixes theReconnectModal.razor.jsinclude path in this case, as reported in https://github.com/dotnet/AspNetCore-ManualTests/issues/3482 (after closing the original issue).<ReconnectModal>element inMainLayout.razordoes not work with global interactivity. This moves the element toApp.razorand updates the import statements in_Imports.razoraccordingly, so that the JS code setting up reconnection event handlers is executed properly in all modes.