Add MVID and MethodToken To Parameters
#7974
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schmittjoseph
added
experimental-feature
...gnostics.Monitoring.StartupHook/ParameterCapturing/Eventing/ParameterCapturingEventSource.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Diagnostics.Monitoring.StartupHook/ParameterCapturing/MethodSignature.cs
Show resolved
Hide resolved
|
Let's also add/update a function test for this -- |
wiktork
reviewed
Feb 28, 2025
| public const int MethodName = 5; | ||
| public const int MethodModuleName = 6; | ||
| public const int MethodDeclaringTypeName = 7; | ||
| public const int MethodToken = 2; |
There was a problem hiding this comment.
This is an interesting scenario to consider for situations where the inproc component stays the same while dotnet-monitor changes. I don't think we have to worry about that yet, but it seems like it would be possible to make this non-breaking change if we wanted to.
There was a problem hiding this comment.
See #7974 (comment) -- this is an intention decision and inline with past decisions around this (#7493 (comment))
wiktork
previously approved these changes
Mar 3, 2025
src/Tests/Microsoft.Diagnostics.Monitoring.Tool.FunctionalTests/ParameterCapturingTests.cs
Outdated
Show resolved
Hide resolved
...icrosoft.Diagnostics.Monitoring.WebApi/ParameterCapturing/CapturedParametersTextFormatter.cs
Outdated
Show resolved
Hide resolved
schmittjoseph
previously approved these changes
Mar 4, 2025
schmittjoseph
previously approved these changes
Mar 5, 2025
jander-msft
reviewed
Mar 5, 2025
src/Microsoft.Diagnostics.Monitoring.StartupHook/ParameterCapturing/MethodSignature.cs
Show resolved
Hide resolved
schmittjoseph
previously approved these changes
Mar 5, 2025
…dotnet-monitor into kkeirstead/paramMVID
schmittjoseph
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added
MVIDandMethodTokento Parameter Capture output.Release Notes Entry
Added
ModuleVersionIdandMethodTokenFields to Parameter Capture Output