[NativeAOT] FormatException instead of ArgumentException in MethodBase.GetMethodFromHandle

[TickThunder]

Description

The JIT throws the correct exception, but NativeAOT does not. And the if condition should use IsGenericType instead of IsConstructedGenericType to be consistent with the JIT and Mono.
like this 1e51807

Reproduction Steps

public class Test<T>
{
    public void f(int a)
    {
        Console.WriteLine(a);
    }
}
public static partial class Program
{
    public static void Main(string[] args)
    {
        MethodBase.GetMethodFromHandle(typeof(Test<int>).GetMethod("f").MethodHandle);
    }
}

Expected behavior

System.ArgumentException:“Cannot resolve method Void f(Int32) because the declaring type of the method handle PInvokeSamples.Test`1[T] is generic. Explicitly provide the declaring type to GetMethodFromHandle.”

Actual behavior

Unhandled Exception: System.FormatException: Index (zero based) must be greater than or equal to zero and less than the size of the argument list.
   at System.ThrowHelper.ThrowFormatIndexOutOfRange() + 0x2b
   at System.Text.ValueStringBuilder.AppendFormatHelper(IFormatProvider, String, ReadOnlySpan`1) + 0x78b
   at System.String.FormatHelper(IFormatProvider, String, ReadOnlySpan`1) + 0x86
   at System.SR.Format(String, Object) + 0xb9
   at System.Reflection.Runtime.General.ReflectionCoreCallbacksImplementation.GetMethodFromHandle(RuntimeMethodHandle) + 0xdd

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response

[TickThunder]

@MichalStrehovsky

[dotnet-policy-service]

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

[huoyaoyuan]

Actually it does aim to support the correct exception, however fails to format the message for the exception. You can take the implementation of CoreCLR at

runtime/src/coreclr/System.Private.CoreLib/src/System/Reflection/MethodBase.CoreCLR.cs

Lines 22 to 26 in 7279752

	Type? declaringType = m?.DeclaringType;
	if (declaringType != null && declaringType.IsGenericType)
	throw new ArgumentException(SR.Format(
	SR.Argument_MethodDeclaringTypeGeneric,
	m, declaringType.GetGenericTypeDefinition()));

.

[TickThunder]

I agree. I had assumed the inconsistencies in NativeAOT's conditional behavior were by design.
Maintain complete consistency with the JIT code. b58376b

[TickThunder]

@agocke cc

[huoyaoyuan]

Since you have found the root cause of the issue, you can submit a PR for it.

[TickThunder]

Sure, let me try it.