Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable FEATURE_RX_THUNKS on Windows #113139

Closed
wants to merge 1 commit into from
Closed

Disable FEATURE_RX_THUNKS on Windows #113139

wants to merge 1 commit into from
+302 −1

Conversation

filipnavara
Copy link
Member

Test for #113114

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Mar 4, 2025
@filipnavara
Disable FEATURE_RX_THUNKS on Windows
Loading
Loading status checks…
a7de3f8
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

@github-actions github-actions bot mentioned this pull request Mar 4, 2025
Closed
@filipnavara
Copy link
Member Author

This is size regression of 46 Kb across the board: MichalStrehovsky/rt-sz#110 (comment)

@MichalStrehovsky
Copy link
Member

/azp run runtime-nativeaot-outerloop

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MichalStrehovsky
Copy link
Member

I scheduled an outerloop run since we don't test NAOT x86 regularly to increase shareholder value.

This is size regression of 46 Kb across the board: MichalStrehovsky/rt-sz#110 (comment)

Oh well. I think we could take it out from those that don't use GetFunctionPointerForDelegate/IDynamicInterfaceCastable somehow.

@filipnavara
Copy link
Member Author

filipnavara commented Mar 4, 2025 •
edited
Loading

Damn. Seems like there is some bitrot afterall. :/

UPD: Ah, I see, it's the section layout that is not specified for the linker.

@filipnavara filipnavara closed this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichalStrehovsky MichalStrehovsky

Assignees
No one assigned
Labels
area-NativeAOT-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@filipnavara @MichalStrehovsky