Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary _DARWIN_C_SOURCE definition in CMake files #112141

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Remove unnecessary _DARWIN_C_SOURCE definition in CMake files #112141

merged 1 commit into from
Feb 28, 2025

Conversation

filipnavara
Copy link
Member

@filipnavara filipnavara commented Feb 4, 2025 •
edited
Loading

We define this globally:

runtime/eng/native/configurecompiler.cmake

Lines 301 to 304 in d44116e

# enable support for X/Open and POSIX APIs, like the <ucontext.h> header file
add_definitions(-D_XOPEN_SOURCE)
# enable support for Darwin extension APIs, like pthread_getthreadid_np
add_definitions(-D_DARWIN_C_SOURCE)

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 4, 2025
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Feb 4, 2025
@filipnavara filipnavara added area-Infrastructure-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Feb 26, 2025
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

@filipnavara
Copy link
Member Author

cc @akoeplinger This has been sitting here without any traction for weeks. Do you know who should review it? Thanks!

@akoeplinger akoeplinger merged commit 577c36c into dotnet:main Feb 28, 2025
79 checks passed
@filipnavara
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

Assignees
No one assigned
Labels
area-Infrastructure-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
Runtime Infra
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filipnavara @akoeplinger