-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DefaultInterpolatedStringHandler.Text/Clear #112171
Conversation
Note regarding the
|
Note regarding the
|
I am wondering if concerns about exposing ValueStringBuilder are not applicable here too. Soon I've copied ValueStingBuilder in our codebase and build a handler like DefaultInterpolatedStringHandler but storage was VSB. Then was asked by colleagues what will happen if they forgot about calling Clear(Dispose in our case). |
An ArrayPool array may not be returned to the pool. |
3456caf
to
3e21110
Compare
Is there any particular reason why |
@hamarb123 valid question; they probably could/should be |
Lots of members could be. Why should these be? Passing around a DefaultInterpolatedStringHandler by |
You're right, upon consideration; adding |
Fixes #110505