-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmarks.run_pgo_optrepeat collection #112750
Conversation
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
@BruceForstall @jakobbotsch @dotnet/jit-contrib opinions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (1)
- src/coreclr/scripts/superpmi-collect.proj: Language not supported
Would also be nice to fix the benchmarks runs to use a release corelib/coreclr and checked jit. |
If we add it, can we replace one of the existing benchmarks collections with it? E.g. do we really feel like we get any use out of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea. We can run it and see how it goes.
Removed. Will merge the PR on Sunday before we do the scheduled re-collect |
/ba-g "naot win-x64 job timed out" |
It'd be nice to have a collection where we can see impact of JitOptRepeat-specific optimizations