Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser] add and load empty ES6 module dotnet.diag.js when FeaturePerfTracing #112787

Merged
merged 18 commits into from
Feb 27, 2025
Merged

[browser] add and load empty ES6 module dotnet.diag.js when FeaturePerfTracing #112787

merged 18 commits into from
Feb 27, 2025

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Feb 21, 2025 •
edited
Loading

  • add and load empty ES6 module dotnet.diag.js when FeaturePerfTracing
  • add dotnet.diag.js.map when FeaturePerfTracing and not publish
  • fix W.B.T.

Contributes to #76316

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-Diagnostics-mono os-browser Browser variant of arch-wasm labels Feb 21, 2025
@pavelsavara pavelsavara added this to the 10.0.0 milestone Feb 21, 2025
@pavelsavara pavelsavara self-assigned this Feb 21, 2025
This was referenced Feb 21, 2025
Open
Open
Open
This was referenced Feb 24, 2025
Open
Closed
@pavelsavara
Copy link
Member Author

enable FeaturePerfTracing when Debug & workload/native

We would not do that because that would trigger re-link in dev inner loop for everyone, making it slower.

@pavelsavara
Merge branch 'main' into browser_diag_js
0b6b080 
# Conflicts:
#	src/mono/browser/runtime/exports-binding.ts
@pavelsavara
more
ddf4999
@pavelsavara pavelsavara marked this pull request as ready for review February 25, 2025 15:13
@Copilot Copilot bot review requested due to automatic review settings February 25, 2025 15:13
Copilot
Copilot AI reviewed Feb 25, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 38 out of 38 changed files in this pull request and generated 1 comment.

maraf
maraf reviewed Feb 26, 2025
View reviewed changes
@pavelsavara @maraf
Update src/mono/wasm/Wasm.Build.Tests/DiagnosticsTests.cs
4f67aef 
Co-authored-by: Marek Fišera <mara@neptuo.com>
maraf
maraf approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@maraf maraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@pavelsavara pavelsavara mentioned this pull request Feb 26, 2025
Open
37 tasks
@build-analysis build-analysis bot mentioned this pull request Feb 26, 2025
Open
@pavelsavara
Copy link
Member Author

/ba-g CI timeouts

@pavelsavara pavelsavara merged commit 7492984 into dotnet:main Feb 27, 2025
151 of 156 checks passed
@pavelsavara pavelsavara deleted the browser_diag_js branch February 27, 2025 06:58
akoeplinger added a commit that referenced this pull request Mar 6, 2025
@akoeplinger
[wasm] Don't log errors for unsupported cases in PInvokeCollector
cd5981c 
After #112787 was merged we saw the runtime being relinked in the runtime tests which uncovered a couple cases where we were throwing an exception or logging an unactionable error in the PInvokeCollector. Log warnings instead and clean up the code.

Fixes #113025
@akoeplinger akoeplinger mentioned this pull request Mar 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot

@maraf maraf

@akoeplinger akoeplinger

@ilonatommy ilonatommy

@lewing lewing

@steveisok steveisok

@vitek-karas vitek-karas

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-Diagnostics-mono os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelsavara @maraf