[workloads] Bump net10 downlevel versions to n-1 #112805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
This was referenced Feb 22, 2025
Open
akoeplinger
approved these changes
Feb 23, 2025
kasperk81
reviewed
Feb 23, 2025
| @@ -31,7 +31,7 @@ public void LibraryModeBuild(string sdk, bool hasWasmAppBundle) | |||
| $""" | |||
| <Project Sdk="{sdk}"> | |||
| <PropertyGroup> | |||
| <TargetFramework>net9.0</TargetFramework> | |||
| <TargetFramework>net10.0</TargetFramework> | |||
There was a problem hiding this comment.
Suggested change
| <TargetFramework>net10.0</TargetFramework> | |
| <TargetFramework>net{Environment.Version}.0</TargetFramework> |
similar to https://github.com/dotnet/runtime/pull/79219/files
There was a problem hiding this comment.
yeah but not worth restarting CI, we can update it in a separate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.