-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix BigInteger.Rotate{Left,Right}
for backport
#112878
Fix BigInteger.Rotate{Left,Right}
for backport
#112878
Conversation
5a3dccd
to
109fdbd
Compare
109fdbd
to
72f2a64
Compare
72f2a64
to
e5151b1
Compare
src/libraries/System.Runtime.Numerics/src/System/Numerics/BigInteger.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime.Numerics/src/System/Numerics/BigInteger.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime.Numerics/src/System/Numerics/BigInteger.cs
Outdated
Show resolved
Hide resolved
a21bf17
to
a65b9c4
Compare
/backport to release/9.0 |
Started backporting to release/9.0: https://github.com/dotnet/runtime/actions/runs/13572166557 |
/backport to release/8.0 |
Started backporting to release/8.0: https://github.com/dotnet/runtime/actions/runs/13572171653 |
@kzrnm Can you clarify your backport requirements for this fix please? Would backporting only to .NET 9 satisfy your needs, or are you still targeting .NET 8? |
@jeffhandley cc. @tannergooding |
Thanks, @kzrnm. We're discussing the backports and trying to balance risk. It would help us to better understand if your scenario is blocked by .NET 8 having this issue, or if backporting only to .NET 9 would unblock you. If you are targeting .NET 9, then we might backport to .NET 9 first and give the fix some more bake time there before backporting to .NET 8. Are you targeting .NET 8 or .NET 9 in your scenario? Thanks again. |
I created the PR for backporting based on #112864 (comment), so I want to leave the decision on whether it should be backported to @tannergooding. To be honest, I don’t have a scenario where I use this method. I reported the bug simply because it returns an obviously incorrect value. |
Fix #112854
In #112864, the whole algorithm is rewritten for .NET 10, but the changes in this PR are minimal.