[PERF] all build jobs used for performance testing are now possible to run inividually #112902
Conversation
e-kharion
requested review from
DrewScoggins,
LoopedBard3,
matouskozak and
caaavik-msft
dotnet-issue-labeler
bot
added
the
needs-area-label
e-kharion
added
area-Infrastructure
perf-pipeline
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
eng/pipelines/performance/templates/perf-ios-scenarios-build-jobs.yml
Outdated
Show resolved
Hide resolved
| - ${{ if containsValue(parameters.jobsAndPlatforms, 'monoPacks') }}: | ||
| # build mono runtime packs | ||
| - template: /eng/pipelines/common/platform-matrix.yml | ||
| parameters: | ||
| jobTemplate: /eng/pipelines/common/global-build-job.yml | ||
| buildConfig: release | ||
| runtimeFlavor: mono | ||
| platforms: | ||
| - android_arm64 | ||
| jobParameters: | ||
| buildArgs: -s mono+libs+host+packs -c $(_BuildConfig) | ||
| nameSuffix: Mono_Packs | ||
| isOfficialBuild: false | ||
| postBuildSteps: | ||
| - template: /eng/pipelines/common/upload-intermediate-artifacts-step.yml | ||
| parameters: | ||
| name: MonoRuntimePacks | ||
| isOfficialBuild: false |
There was a problem hiding this comment.
Not related to this PR as it is just a copy from the old code, but why do we build mono runtime packs with android_arm64 platform?
There was a problem hiding this comment.
No idea tbh. @DrewScoggins ? @LoopedBard3 ? @caaavik-msft ?
There was a problem hiding this comment.
I also do not know. I assume they were getting used at some time. I suppose that is no longer the case?
There was a problem hiding this comment.
The mono runtime packs are used in the building of the perfBDN app. As to why android_arm64 over something like windows_arm64, I don't recall anything specific. I think it was to ensure it was labeled android in the pipeline view for easier picking out, but I don't think there is a requirement for android_arm64.
There was a problem hiding this comment.
Actually, I took another look, the other reason that android_arm64 was chosen is that influences the arch and os that the build.sh command passes in. So by choosing android_arm64, the android packages and what not are built targeting the android OS.
…ndividually added possibility to configure maui framework to use perf-build-jobs splitted to multiple templates perf-arm64-builds moved to a different yml and yml files reorganized
|
Do we also plan to add these configs as selectable values when starting a manual build so that we can limit what we are building for testing scenarios? |
It should be easy if there is buy-in for it. I'd add it, however, in a separate PR, so this one can be merged to unblock follow-up work. |
For perfBisect we need to have a possibility to build specific builds on demand.
This PR should not change the behavior by default, it only adds possibility to build only selected configurations.