Disable GC stress tests for the interpreter test #112906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a problem with the interpreter codegen and GC stress. The runtime is attempting to sprinkle breakpoints in the interpreter IR. Temporarily disable the GC stress for the test until it is fixed.
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
|
The test also fails in pipelines without GCStress, e.g. https://helixr1107v0xdcypoyl9e7f.blob.core.windows.net/dotnet-runtime-refs-heads-main-b10063831ae64414b9/JIT_others/1/console.5c9a5e09.log?helixlogtype=result. It looks like it needs to be disabled more broadly. |
|
Thanks @jakobbotsch for pointing it out. I was not aware of the other crashes. |
|
I've found the culprit for the other issue that @jakobbotsch mentioned. It is a different problem, so this PR makes sense as is. I'll create a PR to fix the other crash. |
Open
3 tasks
BrzVlad
approved these changes
Feb 25, 2025
lewing
reviewed
Feb 25, 2025
Co-authored-by: Larry Ewing <lewing@microsoft.com>
|
Thanks @lewing I haven't noticed that missing newline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a problem with the interpreter codegen and GC stress. The runtime is attempting to sprinkle breakpoints in the interpreter IR.
Temporarily disable the GC stress for the test until it is fixed.