-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add System.Net.ServerSentEvents to runtime shared framework #112930
Conversation
This enables us to support SSE in minimal APIs for dotnet/aspnetcore#56172.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
@ericstj, how should we think about whether System.Net.ServerSentEvents should be in netcoreapp vs aspnetcoreapp? |
If the library is generally useful to all .NET customers and it should be available to libraries that target .NET then it should be in the base netcoreapp shared framework. If it's only needed for folks building aspnet core applications or libraries that are only used in aspnetcore then it can go in the ASP.NET shared framework. My understanding of this library is that it has nothing to do with ASP.NET and can be used by anyone making Http requests - that leads me to believe it should be in the base shared framework, so that would be my suggestion. |
I think I've done the needful to move the library to the runtime shared framework. Let me know if i missed something. |
Now that you switched the library to be part of the Microsoft.NETCore.App shared framework, you need to define its inbox dependencies in the ref and source project. |
This enables us to support SSE in minimal APIs for dotnet/aspnetcore#56172.