Allow R2R for images provided via external_assembly_probe #112934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
dotnet-issue-labeler
bot
added
the
needs-area-label
elinor-fung
added
area-AssemblyLoader-coreclr
and removed
needs-area-label
AaronRobinsonMSFT
approved these changes
Feb 27, 2025
am11
reviewed
Feb 27, 2025
This was referenced Feb 27, 2025
AaronRobinsonMSFT
approved these changes
Feb 27, 2025
ivanpovazan
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow R2R for images provided via
external_assembly_probeThis re-uses the existing mechanism from single-file with R2R, where we load the image by copying it. This is obviously inefficient, but allows a first version of functioning R2R.I tried running the
AndroidSampleApp(regular, R2R, and R2R composite) for the startup scenario in dotnet/performance, but the results for each run had so much variation in my setup (Windows, x64 emulator) that I don't think there was anything to take from it.