Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Use lowered runtime flavor in Android sample app MakeFile #112940

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

matouskozak
Copy link
Member

@matouskozak matouskozak commented Feb 26, 2025

Use lowered runtime flavor in Android sample app MakeFile and abort for unrecognized RUNTIME_FLAVOR.

The previous behavior only accepted "Mono" as a RUNTIME_FLAVOR for building the runtimepack. This could cause unwanted behavior where passing RUNTIME_FLAVOR=mono would lead to building CoreCLR packs instead.

@matouskozak matouskozak self-assigned this Feb 26, 2025
@Copilot Copilot bot review requested due to automatic review settings February 26, 2025 08:11

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Copy link
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@steveisok steveisok merged commit 212d7de into dotnet:main Feb 26, 2025
58 of 61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants