JIT: Skip validation of debug info mappings in optimized codegen #112942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test of time has shown that this test just ends up being another place to modify, and it has never caught anything useful. At the same time it is currently disabling several JIT optimizations to pass, but those optimizations can only be disabled with checked JIT builds, so the test ends up failing in release. Fix dotnet#104451
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
jakobbotsch
changed the title
jakobbotsch
changed the title
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
|
cc @dotnet/jit-contrib |
BruceForstall
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test of time has shown that this test just ends up being another place to modify, and it has never caught anything useful. At the same time it is currently disabling several JIT optimizations to pass, but those optimizations can only be disabled with checked JIT builds, so the test ends up failing in release.
Fix #104451