[wasm] Stop hardcoding TFM in Wasm.Build.Tests

[kasperk81]

#79219 follow up

[akoeplinger]

looks like there are a few compiler errors.

now that I think about it some more I'm also not sure anymore whether this will work when we're between major versions since we might bump Environment.Version before we actually have an sdk that can target that TFM

[kasperk81]

looks like there are a few compiler errors.

were you looking at the error in first commit? it's fixed in second

now that I think about it some more I'm also not sure anymore whether this will work when we're between major versions since we might bump Environment.Version before we actually have an sdk that can target that TFM

doesn't that apply to #79219? haven't heard of any problem in major updates

[akoeplinger]

were you looking at the error in first commit? it's fixed in second

yeah you pushed just when I hit send on my comment :D

doesn't that apply to #79219? haven't heard of any problem in major updates

seems so from a quick glance. we can certainly try it

[kasperk81]

one test timed out

[maraf]

What is the motivation for always passing the TFM instead of leaving it as optional parameter?

[kasperk81]

What is the motivation for always passing the TFM instead of leaving it as optional parameter?

to make it compile. static readonly can't be used as default parameter and can't use Version.Major in const.

[maraf]

to make it compile. static readonly can't be used as default parameter and can't use Version.Major in const.

That's fair. Although I would prefer to use null as default and set it to DefaultTFM instead of having to pass the DefaultTFM everywhere.

[kasperk81]

changed to null defaults

[akoeplinger]

looks great, left a couple comments

[akoeplinger]

I'm a little bit worried that we'll forget updating the earlier versions here.
Should we introduce a int MinimumTargetFramwork = 8 in BuildTestBase.cs and then here return all TFMs from MinimumTargetFramwork => DefaultTargetFramework?

[kasperk81]

there are two old versions at max and in other places net7 and net6 were used. i've removed them and added Previous2 property. when it's time for net 11, it will be testing one STS version which may not be ideal in second half of the year (when it goes out of support) but won't break anything if nuget.config keeps dotnet9 for a while.