Fix exception propagation from managed to native on Unix #112957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new exception handling on Unix doesn't prevent propagation of exceptions from managed to external native code like the old one did. Instead of reporting an unhandled exception, it rethrows the PAL_SEHException that later ends up being reported as C++ unhandled exception. This change fixes that behavior by enabling exception propagation from managed to native code only for the case when the native caller is CallDescrWorkerInternal.
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
jkotas
approved these changes
Feb 26, 2025
|
Hmm, something doesn't work as expected, lot of the tests are failing. I am looking into it. |
This was referenced Feb 27, 2025
Open
When doing final rebasing on main where the IsCallDescrWorkerInternalReturnAddress was added in the meanwhile, I've acidentally caused the condition to be reverse for the added check. That caused the CI test failures.
The exception in filter was incorrectly rejected as coming from external native code
|
@janvorli Is this already released or planned for a patch release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new exception handling on Unix doesn't prevent propagation of exceptions from managed to external native code like the old one did. Instead of reporting an unhandled exception, it rethrows the PAL_SEHException that later ends up being reported as C++ unhandled exception.
This change fixes that behavior by enabling exception propagation from managed to native code only for the case when the native caller is CallDescrWorkerInternal.
Close #112497