Delete unused legacy hosting flags #112975
Conversation
There was a problem hiding this comment.
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
|
Tagging subscribers to this area: @mangod9 |
| // Fortunately, we should never get into this case, since the thread flag about | ||
| // ignoring unhandled exceptions cannot be set on the default domain. | ||
|
|
||
| BOOL fIsProcessTerminating = !(AppDomain::GetCurrentDomain()->IgnoreUnhandledExceptions()); |
There was a problem hiding this comment.
This functionality is superseded by #101560
There was a problem hiding this comment.
// Fortunately, we should never get into this case, since the thread flag about
// ignoring unhandled exceptions cannot be set on the default domain.
Does this mean the feature could not be enabled on CoreCLR?
There was a problem hiding this comment.
This comment is wrong. It could be enabled on CoreCLR if somebody uses untested and undocumented APPDOMAIN_IGNORE_UNHANDLED_EXCEPTIONS flag on the unsupported legacy CoreCLR hosting API.
| STARTUP_LOADER_OPTIMIZATION_MASK = 0x3<<1, // loader optimization mask | ||
| STARTUP_LOADER_OPTIMIZATION_SINGLE_DOMAIN = 0x1<<1, // no domain neutral loading | ||
| STARTUP_LOADER_OPTIMIZATION_MULTI_DOMAIN = 0x2<<1, // all domain neutral loading | ||
| STARTUP_LOADER_OPTIMIZATION_MULTI_DOMAIN_HOST = 0x3<<1, // strong name domain neutral loading |
There was a problem hiding this comment.
There is LoaderOptimizationAttribute specifying these flags. Now all the flags are deprecated, should the attribute be considered for deprecation?
There was a problem hiding this comment.
Possibly. I think you can find number of attribute types that were added for compatibility with .NET Framework and that have no effect in .NET Core.
No description provided.