Remove ValidationContext.MemberType

[eerhardt]

This property is unused, and is only ever set. It has an UnconditionalSuppressMessage suppression, which makes it hard to tell if there is a trimming issue here or not.

Since this code isn't used, it is better to just remove it to make the trim analysis of this class easier.

PR Overview

This PR removes the unused property MemberType from ValidationContext to simplify trim analysis.

• Removed the assignment to MemberType from the Validator's CreateValidationContext call.
• Removed the MemberType property definition and its backing field from ValidationContext.

Reviewed Changes

File	Description
Validator.cs	Removed usage of the unused MemberType property from the validation context.
ValidationContext.cs	Deleted the unused MemberType property and its backing field to simplify trimming analysis.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

[stephentoub]

If it builds, LGTM

[tarekgh]

Hopefully no-one using it through the reflection.

[eerhardt]

Hopefully no-one using it through the reflection.

If they are.... they shouldn't be. 😄

[ericstj]

Testing something:

This pull request focuses on the removal of the MemberType property and its associated logic from the ValidationContext class in the System.ComponentModel.DataAnnotations namespace. This change simplifies the code and removes unnecessary complexity related to property type retrieval.

The most important changes include:

Removal of MemberType Property:

• src/libraries/System.ComponentModel.Annotations/src/System/ComponentModel/DataAnnotations/ValidationContext.cs: Removed the MemberType property and its associated logic, including the _propertyType private field and the UnconditionalSuppressMessage attribute.

Related Adjustments:

• src/libraries/System.ComponentModel.Annotations/src/System/ComponentModel/DataAnnotations/Validator.cs: Removed the line that sets the MemberType property in the GetObjectPropertyValidationErrors method, as the property no longer exists.

[eerhardt]

It's been a while since I contributed here. I'm not sure what I'm supposed to do to be able to merge this. Do I rerun the failed legs? The one leg appears to be stuck.

[stephentoub]

/ba-g unrelated numeric test failure

[stephentoub]

It's been a while since I contributed here. I'm not sure what I'm supposed to do to be able to merge this. Do I rerun the failed legs? The one leg appears to be stuck.

Generally you look at the Build Analysis leg. It correctly identified known test and infra failures, and then called out one unknown test failure, but that failure was unrelated, in System.Numerics. I used the /ba-g command ("build analysis - green") to tell it we're good, and that unblocked the ability to merge, which you're good to do.

[eerhardt]

Thanks for the help @stephentoub!