Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cDAC] fix condition to only link in native unwinders on Windows x64 #112999

Merged
merged 4 commits into from
Feb 27, 2025

Conversation

max-charlamb
Copy link
Contributor

#111759 broke Windows non-x64 builds by trying to link native unwinders which didn't exist.

Adds conditional to only link unwinders on Windows x64

@Copilot Copilot bot review requested due to automatic review settings February 27, 2025 20:34

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 27, 2025
@max-charlamb max-charlamb added area-Diagnostics-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Feb 27, 2025
Copy link
Contributor

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

@steveisok
Copy link
Member

/ba-g Merging to unblock official build.

@steveisok steveisok merged commit b0e9b73 into dotnet:main Feb 27, 2025
43 of 123 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants