Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc fixes for .NET 10 Preview 1 update #113027

Merged
merged 5 commits into from
Mar 6, 2025

Conversation

gewarren
Copy link
Contributor

See dotnet/dotnet-api-docs#11032 build report.

@Copilot Copilot bot review requested due to automatic review settings February 28, 2025 23:08
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR updates XML documentation comments for .NET 10 Preview 1 by replacing tags with tags and by standardizing boolean return values using and for consistency.

  • Updated XML documentation in PhysicalFileProvider.cs
  • Standardized boolean documentation in various AsyncEnumerable files

Reviewed Changes

File Description
src/libraries/Microsoft.Extensions.FileProviders.Physical/src/PhysicalFileProvider.cs Replaced with in doc comments for clarity.
src/libraries/System.Linq.AsyncEnumerable/src/System/Linq/AnyAsync.cs Updated boolean return documentation markup.
src/libraries/System.Linq.AsyncEnumerable/src/System/Linq/AllAsync.cs Updated boolean return documentation markup.
src/libraries/System.Linq.AsyncEnumerable/src/System/Linq/ContainsAsync.cs Updated boolean return documentation markup.
src/libraries/System.Linq.AsyncEnumerable/src/System/Linq/SequenceEqualAsync.cs Updated boolean return documentation markup.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

@gewarren gewarren requested a review from carlossanlop March 4, 2025 16:48
Copy link
Member

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume these were fixed in source too?

@gewarren
Copy link
Contributor Author

gewarren commented Mar 4, 2025

I assume these were fixed in source too?

This is the source. I didn't fix in the API docs repo since I assume the XML file is refreshed for each preview?

@carlossanlop
Copy link
Member

Microsoft.Extensions have triple slash comments as source of truth.

This is the source

This is confusing me 😅

@gewarren
Copy link
Contributor Author

gewarren commented Mar 6, 2025

@carlossanlop I'm not sure how to get this merged. By the time the checks finish, the branch is out of date.

@carlossanlop
Copy link
Member

carlossanlop commented Mar 6, 2025

Don't press Update branch.
The CI is showing failures, so "Build Analysis" is blocking the merge button.

If none of the failures is related to your changes, you can override that leg with a comment that starts with "/ba-g" followed by a brief explanation of your investigation confirming the failures are unrelated.

@carlossanlop carlossanlop reopened this Mar 6, 2025
@carlossanlop
Copy link
Member

carlossanlop commented Mar 6, 2025

/ba-g failures are BadExit, they're unrelated. Sorry I pressed close.

@carlossanlop carlossanlop merged commit a98f3c3 into dotnet:main Mar 6, 2025
74 of 84 checks passed
@gewarren gewarren deleted the docs-physicalfileprovider branch March 6, 2025 00:51
@gewarren
Copy link
Contributor Author

gewarren commented Mar 6, 2025

Thanks @carlossanlop!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants