[browser] avoid locks in ST interop #113046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelsavara
added
arch-wasm
lewing
reviewed
Mar 4, 2025
maraf
approved these changes
Mar 6, 2025
|
/ba-g CI timeouts |
akoeplinger
reviewed
Mar 6, 2025
src/libraries/System.Private.CoreLib/src/System/Threading/ManualResetEventSlim.cs
Show resolved
Hide resolved
IDisposable
reviewed
Mar 6, 2025
...nteropServices.JavaScript/src/System/Runtime/InteropServices/JavaScript/CancelablePromise.cs
Show resolved
Hide resolved
|
can you backport to release/9.0 ? |
IDisposable
added a commit
to IDisposable/dotnet-runtime
that referenced
this pull request
Mar 7, 2025
The '#ifdef` being tested is already known to be true because we're in the `#else` block of the previous test of `!FEATURE_WASM_MANAGED_THREADS` which is the same thing we were testing. Noted in [this comment](dotnet#113046 (comment))
I'm not sure perf meets the risk/value requirements for the backport. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #112734