Assert pointer relocs are aligned #113069
Open
+17
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This pull request introduces debug assertions to ensure pointer relocations are properly aligned during object emission.
- Adds a DEBUG-only block to iterate over relocations and check for pointer relocation alignment
- Verifies the node content's alignment against the target pointer size
Reviewed Changes
| File | Description |
|---|---|
| src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/ObjectWriter/ObjectWriter.cs | Introduces debug assertions ensuring pointer relocs and node alignment are verified |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
filipnavara
approved these changes
Mar 3, 2025
Comment on lines
+457
to
+462
| if ((reloc.RelocType is RelocType.IMAGE_REL_BASED_DIR64 && _nodeFactory.Target.PointerSize == 8) || | ||
| (reloc.RelocType is RelocType.IMAGE_REL_BASED_HIGHLOW && _nodeFactory.Target.PointerSize == 4)) | ||
| { | ||
| hasPointerRelocs = true; | ||
| Debug.Assert(reloc.Offset % _nodeFactory.Target.PointerSize == 0); | ||
| } |
There was a problem hiding this comment.
The stack trace metadata node uses unaligned pointer relocs. Everything else is (AFAIK) aligned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.