Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not cache method parameters for collectible methods #113085

Merged

Conversation

tbdty
Copy link
Contributor

@tbdty tbdty commented Mar 3, 2025

When using a method from a generic class from a non-collectible assembly with a generic parameter from a collectible assembly in a LINQ expression, the collectible assembly may be prevented from unloading. This is due to the method parameters being cached in a dictionary with the method info.

Fix #112518

When using a method from a generic class from a non-collectible assembly
with a generic parameter from a collectible assembly in a LINQ expression,
the collectible assembly may be prevented from unloading. This is due to the
method parameters being cached in a dictionary with the method info.

Fix dotnet#112518
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Mar 3, 2025
Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas jkotas merged commit 6c4e699 into dotnet:main Mar 3, 2025
85 checks passed
@tbdty tbdty deleted the system-linq-expressions-fix-assembly-unloading branch March 4, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.Linq.Expressions community-contribution Indicates that the PR has been added by a community member
Projects
None yet
2 participants